Feeling Lucky
?
[#32052] - [4] fix Notice: Only variables should be passed by reference
- Fixed in Code Base
- 16 Jan 2021
- Medium
- Build: 4.0-dev
- # 32052
- Diff
- PhilETaylor:arraypopreference
User tests: Successful: Unsuccessful:
Code review
Test case: https://3v4l.org/OQacn
<?php
$command = ['one'=>1,"two"=>2,"three"=>3];
$keys = array_keys($command);
// Raises a notice
var_dump(array_pop(array_keys($command)));
echo "\n\n\n\n";
var_dump(array_pop($keys));| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
gostn
- comment
- 16 Jan 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32052.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 16 Jan 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32052.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-16 08:25:08 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
HLeithner
- comment
- 16 Jan 2021
thanks
I have tested this item✅ successfully on 80ad3ae
Tested successfully in Beta7-dev of 16 January.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32052.