Feeling Lucky
?
[#32003] - [4] Remove return after an exception (copy and paste legacy issue)
- Fixed in Code Base
- 11 Jan 2021
- Medium
- Build: 4.0-dev
- # 32003
- Diff
- PhilETaylor:patch-61
User tests: Successful: Unsuccessful:
Summary of Changes
On code review.
Before Joomla 4 this was a JError::raiseError(...) call and not an Exception so the return made sense then
Now we throw Exception there is no way to reach the return false; and therefore its redundant unreachable code
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_contenthistory |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-11 08:41:22 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
infograf768
- comment
- 11 Jan 2021
Thanks!