[#31997] - [4] remove redundant code in frontend template manager
- Fixed in Code Base
- 10 Jan 2021
- Medium
- Build: 4.0-dev
- # 31997
- Diff
- PhilETaylor:comconfigtemplates
User tests: Successful: Unsuccessful:
Summary of Changes
remove code smell and correctly load the form for frontend template config
$form was created twice, directly overwriting itself as soon as it was loaded.
Testing Instructions
Install testing data on Joomla 4
login to FRONTEND
click "Template Settings" in the right hand side menu
Actual result BEFORE applying this Pull Request
Page loads
Expected result AFTER applying this Pull Request
Page loads - but with less code to power it
Documentation Changes Required
none - code review only
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_config |
| Title |
|
||||||
Go to Joomla 4 Admin
Home Dashboard
Look for
Press the first blue Install button.
My Beta7-dev does not have it, just Blog Sample Data and Multilingual Sample Data. Discover did not find that module either.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31997.
The testing data plugin is only available on github. It is never included in a joomla release. It is very very broken
This resolved issue in this PR is totally unrelated to the testing data.
The mention of the testing data plugin in this PR is purely a quick way to get a link to Template Settings on the frontend, instead of explaining how to create a new menu item of kind template settings.
Simples! Done.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31997.
I have tested this item
Tested successfully in Beta7-dev of 10 January.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31997.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-10 22:14:39 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
@PhilETaylor where is the testing data with the right hand side menu available from?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31997.