Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31995] - [4] Remove return after an exception (copy and paste legacy issue)

? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
10 Jan 2021

Summary of Changes

On code review.

Before Joomla 4 this was a JError::raiseError(...) call and not an Exception so the return made sense then

Now we throw Exception there is no way to reach the return false; and therefore its redundant unreachable code

avatar PhilETaylor PhilETaylor - open - 10 Jan 2021
avatar PhilETaylor PhilETaylor - change - 10 Jan 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2021
Category ⇒ Front End com_users
avatar PhilETaylor PhilETaylor - change - 10 Jan 2021
Title
…
[4b6] remove return after an exception (copy and paste legacy issue)
[4] Remove return after an exception (copy and paste legacy issue)
avatar PhilETaylor PhilETaylor - edited - 10 Jan 2021
avatar toivo
toivo - comment - 10 Jan 2021

I have tested this item ✅ successfully on d69d705

Tested successfully in Beta7-dev of 10 January.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31995.

avatar toivo toivo - test_item - 10 Jan 2021 - Tested successfully
avatar wilsonge wilsonge - close - 10 Jan 2021
avatar wilsonge wilsonge - merge - 10 Jan 2021
avatar wilsonge wilsonge - change - 10 Jan 2021
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-01-10 22:08:12
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 10 Jan 2021

Thanks!

avatar infograf768
infograf768 - comment - 11 Jan 2021

Looks like we have another one

joomla-cms/administrator/components/com_contenthistory/src/View/Preview/HtmlView.php

Lines 58 to 60 in 4d54941

throw new \Exception(Text::_('COM_CONTENT_ERROR_ARTICLE_NOT_FOUND'), 404);
return false;

avatar PhilETaylor
PhilETaylor - comment - 11 Jan 2021

@infograf768 #32003

Add a Comment

Login with GitHub to post a comment