? Pending

User tests: Successful: Unsuccessful:

avatar Razzo1987
Razzo1987
9 Jan 2021

We do not need H tags in nested ul items

Pull Request for Issue #31942 .

Summary of Changes

I removed the lines of code that generate H tags.

Testing Instructions

create nested categories of content like:
image

Is can be usefully import Sample Data and then move the category.

Create a module of Articles - Categories with these settings:
image

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

NO

avatar Razzo1987 Razzo1987 - open - 9 Jan 2021
avatar Razzo1987 Razzo1987 - change - 9 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jan 2021
Category Modules Front End
avatar brianteeman
brianteeman - comment - 9 Jan 2021

That removes the different styling of the nested list

avatar Razzo1987
Razzo1987 - comment - 9 Jan 2021

@brianteeman yes, because it's wrong.
If you have more then 6 level the H tag become incorrect.
We have the UL indentation for understand the level

avatar brianteeman
brianteeman - comment - 9 Jan 2021

@Razzo1987 very good point

avatar Razzo1987 Razzo1987 - change - 9 Jan 2021
The description was changed
avatar Razzo1987 Razzo1987 - edited - 9 Jan 2021
avatar brianteeman
brianteeman - comment - 10 Jan 2021

I have tested this item successfully on 0cbbf0c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31958.

avatar brianteeman brianteeman - test_item - 10 Jan 2021 - Tested successfully
avatar wilsonge wilsonge - change - 10 Jan 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-10 00:53:49
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 10 Jan 2021
avatar wilsonge wilsonge - merge - 10 Jan 2021
avatar wilsonge
wilsonge - comment - 10 Jan 2021

Makes sense to me. Thanks!

Add a Comment

Login with GitHub to post a comment