Feeling Lucky
?
[#31945] - [4] return built in constants instead of hand typed integers
- Fixed in Code Base
- 10 Jan 2021
- Medium
- Build: 4.0-dev
- # 31945
- Diff
- PhilETaylor:commandreturn
User tests: Successful: Unsuccessful:
Summary of Changes
Symfony provides Command::SUCCESS and Command::FAILURE return statuses
This PR replaces hand typed integers with those constants
AND Bonus: Fixes typo in CONFIG_GET_OPTION_NOT_FOUND in libraries/src/Console/GetConfigurationCommand.php
The Command::SUCCESS and Command::FAILURE constants were introduced in Symfony 5.1.
Testing Instructions
run commands
Actual result BEFORE applying this Pull Request
All commands work and return exit codes appropriate to their exit status
Expected result AFTER applying this Pull Request
All commands work and return exit codes appropriate to their exit status while reusing built in Class Constants provided by \Symfony\Component\Console\Command\Command
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-10 00:57:19 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Merged on review