Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31940] - [4.0] Banner TracksExport modal

? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
9 Jan 2021

Pull Request for Issue #31926 .

Summary of Changes

The modal was rendering with an a instead of a button

In investigating this I found that the modal was not using the code in the view but the code in a layout.

This PR removes the unused code in the view and corrects the link in the layout.

I do not really understand why this is a layout

Testing Instructions

Apply the pr and check that the export tracks modal still works
View the source and check that the cancel button is using button markup

avatar brianteeman brianteeman - open - 9 Jan 2021
avatar brianteeman brianteeman - change - 9 Jan 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jan 2021
Category ⇒ Administration com_banners Layout
avatar richard67
richard67 - comment - 9 Jan 2021

@brianteeman Does your PR solve issue #31926 completely so the issue can be closed?

avatar brianteeman
brianteeman - comment - 9 Jan 2021

yes

avatar chmst
chmst - comment - 9 Jan 2021

I have tested this item ✅ successfully on 9e5a291

It works. But on windows, the button is styled as it was before, no matter if it is the correct button tag or the wrong a tag (firefox on win10).

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31940.

avatar chmst chmst - test_item - 9 Jan 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 9 Jan 2021

@chmst I can't test on a mac either :(
even if it doesnt fix the reported problem (it should but who knows) the pr is still valid as its clearly a bug

avatar PhilETaylor
PhilETaylor - comment - 9 Jan 2021

This PR breaks the site due to a trailing comma highlighted in red in phpStorm

Trailing comma's in function calls is a PHP 7.3 feature and Joomla 4 needs to be able to run on PHP 7.2. https://laravel-news.com/php-trailing-commas-functions

Screenshot 2021-01-09 at 13 33 53

Screenshot 2021-01-09 at 13 32 29

avatar brianteeman brianteeman - change - 9 Jan 2021
Labels Added: ?
avatar ceford
ceford - comment - 10 Jan 2021

I have tested this item ✅ successfully on 046d2d9

Confirmed working as described in Firefox and Safari on Mac OSX.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31940.

avatar ceford ceford - test_item - 10 Jan 2021 - Tested successfully
avatar gostn
gostn - comment - 10 Jan 2021

I have tested this item ✅ successfully on 046d2d9

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31940.

avatar gostn gostn - test_item - 10 Jan 2021 - Tested successfully
avatar alikon alikon - change - 10 Jan 2021
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 10 Jan 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31940.

avatar chmst chmst - close - 10 Jan 2021
avatar chmst chmst - merge - 10 Jan 2021
avatar chmst chmst - change - 10 Jan 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-01-10 09:18:04
Closed_By ⇒ chmst
Labels Added: ?
avatar chmst
chmst - comment - 10 Jan 2021

Thanks

avatar brianteeman
brianteeman - comment - 10 Jan 2021

Thank you

Add a Comment

Login with GitHub to post a comment