Forgotten to change the settings after copying?

Seems to be copied cache settings now.

my bad
fixed

I have tested this item ✅ successfully on 0a51ec2

Tested successfully in Beta7-dev of 9 January.

Keep returning the error:

Symfony\Component\ErrorHandler\Error\UndefinedFunctionError^ {#142
  #message: "Attempted to call function "simplexml_load_file" from namespace "Joomla\CMS\Language"."
  #code: 0
  #file: "./libraries/src/Language/LanguageHelper.php"
  #line: 680
  trace: {
    ./libraries/src/Language/LanguageHelper.php:680 {
      Joomla\CMS\Language\LanguageHelper::parseXMLLanguageFile($path)^
      › // Try to load the file
      › $xml = simplexml_load_file($path);
      › 
    }
    ./libraries/src/Language/LanguageHelper.php:572 { …}
    ./libraries/src/Language/Language.php:193 { …}
    ./libraries/src/Language/LanguageFactory.php:32 { …}
    ./libraries/src/Language/CachingLanguageFactory.php:43 { …}
    ./libraries/src/Service/Provider/Application.php:121 { …}
    ./libraries/vendor/joomla/di/src/ContainerResource.php:176 { …}
    ./libraries/vendor/joomla/di/src/Container.php:96 { …}
    ./cli/joomla.php:67 { …}
  }
}

@Razzo1987 looks like your PHP setup is missing lib-xml

I have tested this item ✅ successfully on 0a51ec2

RTC

This isn't going to be enough. We're going to need to cover configuration.php files for people upgrading from Joomla 3.10

back to pending for cover update from 3.10

This isn't going to be enough. We're going to need to cover configuration.php files for people upgrading from Joomla 3.10

Don't they automatically get the cors settings added to the configuration.php as soon as they save the global config for the first time AND as its disabled by default it doesnt matter if they dont do it

Don't they automatically get the cors settings added to the configuration.php as soon as they save the global config for the first time AND as its disabled by default it doesnt matter if they dont do it

For the actual API yes, but per the original issue apparently something breaks inside com_config CLI endpoint

That looks better but it needs to cover cases on further updates where these values are already set

public function postflight($action, $installer)
{
	if ($action !== 'update')
	{
		return true;
	}


	if (empty($this->fromVersion) || version_compare($this->fromVersion, '4.0.0', 'ge'))
	{
		return true;
	}

the postflight runs on update from version less than 4.0.0

I.e. it never runs when updating a previous beta which doesn't have the new settings?

it runs on previous beta too....
as an example

$old='4.0.0-beta4-dev';
version_compare($old, '4.0.0', 'ge');  // return false