[#31924] - [4b6] role=presentation? when an image is decorative only.
- Closed
- 10 Jan 2021
- Medium
- Build: staging
- # 31924
Steps to reproduce the issue
Using the media managers new "No description" tick box when selecting an image gives markup of
<p><img src="images/joomla_black.png" alt="" /></p>
however if you then right click that inserted image in TinyMCE (because intuitive double click does nothing)
and select "Image" context menu item you get another popup with "Image is decorative" unchecked
If I then check that checkbox and click save the generated markup is now
<p><img role="presentation" src="images/joomla_black.png" alt="" width="225" height="50" /></p>
So the question is, should the Joomla Media Manager be adding role="presentation" when the "No description" checkbox is ticked?
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
This would also apply I guess to the rendering of other images with other checkboxes like these:
role=presentation is an alternative method to alt=""
However its not as widely supported so the current code from joomla is perfectly correct
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31924.
This should be closed as not an issue
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-10 10:50:29 |
| Closed_By | ⇒ | chmst |
I wanted to move it to discussion but seems that github is not ready for that
The issue is that joomla now has two totally different ways of doing the same thing (marking an image as decorative only) that are incompatible with each other.
Enabling through media manager doesn't add the role so tinymce doesn't believe it's a decorative image.
The quick fix would be for joomla to add the alt and the role. From my googling that is not invalid syntax and just covers all bases.
If tinymce is going to remain shipped as the default editor it makes sense to be compatible with its features
Moving issues to discussions is a feature that has been revoked by GitHub after they found that comments were lost during the process occasionally. I hear they are recoding and that feature will return.
Tagging @brianteeman as it seems you were close to this?