ok Found it.

The first issue should be ok as an attribute can be interpreted by PHP 7.2 as a comment.

Attributes are only allowed since PHP 8.0 in libraries/vendor/symfony/service-contracts/Attribute/Required.php

#[Attribute(Attribute::TARGET_METHOD | Attribute::TARGET_PROPERTY)]

The second issue is "Classes named String are forbidden in PHP 7"
in file. libraries/vendor/joomla/filesystem/src/Stream/String.php which is already deprecated.

class String extends StringWrapper

So we just ignore this right?

For the comment I think we have to ignore it but the filesystem package is interesting.

Because it seems that composer pulls joomla/filesystem 1.3 and not 2.0, the cms doesn't have a direct dependency on the Filesystem package and all dependencies require ^1.3| ^2.0 I'm not sure if it's intended to use 1.3 package in j4.

/cc @wilsonge

I suspect it's because composer is preferring the stable tag of the filesystem package. I suspect when we tag a 2.0 stable for the filesystem package we will pull in that. I'll tag a release blocker here to check. But I don't think there's explicitly anything we can do until we go to tag framework packages

The symfony service contracts are tagged as 7.2.5 and higher. So I think we're pretty safe there. Just an IntelliJ bug

we can require ^2.0 in the cms because at the moment we test with the old version which should do the same but isn't the same code. When do we plan to tag stable for the framework?

Maybe this is true for other packages?

When do we plan to tag stable for the framework?

Unsure. Shouldn't be too long after we put the CMS into RC. A few weeks minimum before we tag stable in the CMS...

I don't think we should add explicit requires in the CMS for things we don't depend on...

To be honest we probably need to look at decoupling the filesystem package from the archive package anyhow because I don't think the archive package will inherit our FTP settings anyhow :/

As far as I can see, the archive package has meanwhile been tagged with 2.0 Beta 4, which includes the change from PR joomla-framework/archive#26 , so what remains to be done is to update the CMS with that Beta 4 (it still used Beta 2 as far as I can see). Or am I missing something?

This should be closed now