User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
?
|
I would not add this without the possibility to disable this.
Why?
I'm not so sure that everyone likes this , I'm not even sure if I like it. I think It would distract me.
Then you can disable tinymce ;)
Tinymce was already doing this for tables.
You will only ever see it when you select some text (that;s why i disabled the other options which are always visible)
It's not so funny if you select text for reading like Me any many others. I always hate websites that thinks a popup menu is a good idea when text is selected
this is in the editor!!
I know, isn't it allowed to prove read the text? But I don't say that it's bad for everyone, for me it's a usability issue. Thats the reason it should be an option, btw. I think all plugins should be configurable by the user/plugin.
Accept this pr or not. The code is correct and I'm not changing it
I think this is a nice feature. I like it.
Since you leave the decision to me I reject this pr, not because I find it distracting, mainly because it should be configurable. We have a awesome possibility to create own toolbars for each user group in the tinymce plugin. This quickbar is not different and should be configurable like the other toolbars.
beside that you have always the possibility to add the quickbar in the custom_plugin input field
but it's not possible to deactivate a plugin.
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-09 10:13:17 |
Closed_By | ⇒ | HLeithner | |
Labels |
Where did I say it was up to you. You are not the god of joomla 4. And if you actually tried it you would see that the custom plugin thing you talk of is no use here.
@wilsonge you are the release lead not @HLeithner Since when did he have the right to reject something because he doesnt like it. Thats not how it works.
Then I miss understood you sorry
Status | Closed | ⇒ | New |
Closed_Date | 2021-01-09 10:13:17 | ⇒ | |
Closed_By | HLeithner | ⇒ | |
Labels |
Removed:
?
|
Status | New | ⇒ | Pending |
@HLeithner set RTC again!
@wilsonge you are the release lead not @HLeithner Since when did he have the right to reject something because he doesnt like it. Thats not how it works.
Anyone in maintainers can reject basic features, normally release leads just sit over the major ones. he does have the power.
Unfortunately for Harald I do kinda like this feature though :)
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-10 00:46:27 |
Closed_By | ⇒ | wilsonge |
Thank you
It didn't rejected it as feature I rejected it because of the poor implementation and that it's not possible to disable it like the markdown plugin. I wrote this in my comment but that got ignored by brian and only thing that got left on twitter was an attack against me.
Buy yeah when brian has done a pr nobody is allowed to help improving it.
I didnt ignore it. I just didnt accept it.
I have tested this item✅ successfully on 5a78331
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31895.