? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
8 Jan 2021

Shown when text is selected, providing formatting buttons such as: bold, italic, and link.

image

To test just apply the pr and in the editor select some text.

avatar brianteeman brianteeman - open - 8 Jan 2021
avatar brianteeman brianteeman - change - 8 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jan 2021
Category Front End Plugins
avatar Quy
Quy - comment - 8 Jan 2021

I have tested this item successfully on 5a78331


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31895.

avatar Quy Quy - test_item - 8 Jan 2021 - Tested successfully
avatar richard67
richard67 - comment - 8 Jan 2021

I have tested this item successfully on 5a78331


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31895.

avatar richard67 richard67 - test_item - 8 Jan 2021 - Tested successfully
avatar richard67 richard67 - change - 8 Jan 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 8 Jan 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31895.

avatar richard67 richard67 - change - 8 Jan 2021
Labels Added: ? ?
avatar HLeithner
HLeithner - comment - 8 Jan 2021

I would not add this without the possibility to disable this.

avatar richard67
richard67 - comment - 8 Jan 2021

Why?

avatar HLeithner
HLeithner - comment - 8 Jan 2021

I'm not so sure that everyone likes this , I'm not even sure if I like it. I think It would distract me.

avatar brianteeman
brianteeman - comment - 8 Jan 2021

Then you can disable tinymce ;)

Tinymce was already doing this for tables.

You will only ever see it when you select some text (that;s why i disabled the other options which are always visible)

avatar HLeithner
HLeithner - comment - 8 Jan 2021

It's not so funny if you select text for reading like Me any many others. I always hate websites that thinks a popup menu is a good idea when text is selected

avatar brianteeman
brianteeman - comment - 8 Jan 2021

this is in the editor!!

avatar HLeithner
HLeithner - comment - 8 Jan 2021

I know, isn't it allowed to prove read the text? But I don't say that it's bad for everyone, for me it's a usability issue. Thats the reason it should be an option, btw. I think all plugins should be configurable by the user/plugin.

avatar brianteeman
brianteeman - comment - 9 Jan 2021

Accept this pr or not. The code is correct and I'm not changing it

avatar TobsBobs
TobsBobs - comment - 9 Jan 2021

I think this is a nice feature. I like it.

avatar HLeithner
HLeithner - comment - 9 Jan 2021

Since you leave the decision to me I reject this pr, not because I find it distracting, mainly because it should be configurable. We have a awesome possibility to create own toolbars for each user group in the tinymce plugin. This quickbar is not different and should be configurable like the other toolbars.
image

beside that you have always the possibility to add the quickbar in the custom_plugin input field
image

but it's not possible to deactivate a plugin.

avatar HLeithner HLeithner - change - 9 Jan 2021
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2021-01-09 10:13:17
Closed_By HLeithner
Labels
avatar HLeithner HLeithner - close - 9 Jan 2021
avatar brianteeman
brianteeman - comment - 9 Jan 2021

Where did I say it was up to you. You are not the god of joomla 4. And if you actually tried it you would see that the custom plugin thing you talk of is no use here.

@wilsonge you are the release lead not @HLeithner Since when did he have the right to reject something because he doesnt like it. Thats not how it works.

avatar HLeithner
HLeithner - comment - 9 Jan 2021

Then I miss understood you sorry

avatar HLeithner HLeithner - change - 9 Jan 2021
Status Closed New
Closed_Date 2021-01-09 10:13:17
Closed_By HLeithner
Labels Removed: ?
avatar HLeithner HLeithner - change - 9 Jan 2021
Status New Pending
avatar HLeithner HLeithner - reopen - 9 Jan 2021
avatar gostn
gostn - comment - 9 Jan 2021

@HLeithner set RTC again!

avatar infograf768
infograf768 - comment - 9 Jan 2021

Can you add underline to get
'quickbars_selection_toolbar' => 'bold italic | H2 H3 | link blockquote underline',

Screen Shot 2021-01-09 at 18 53 17

avatar wilsonge
wilsonge - comment - 10 Jan 2021

@wilsonge you are the release lead not @HLeithner Since when did he have the right to reject something because he doesnt like it. Thats not how it works.

Anyone in maintainers can reject basic features, normally release leads just sit over the major ones. he does have the power.

Unfortunately for Harald I do kinda like this feature though :)

avatar wilsonge wilsonge - change - 10 Jan 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-10 00:46:27
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 Jan 2021
avatar wilsonge wilsonge - merge - 10 Jan 2021
avatar brianteeman
brianteeman - comment - 10 Jan 2021

Thank you

avatar HLeithner
HLeithner - comment - 10 Jan 2021

It didn't rejected it as feature I rejected it because of the poor implementation and that it's not possible to disable it like the markdown plugin. I wrote this in my comment but that got ignored by brian and only thing that got left on twitter was an attack against me.

Buy yeah when brian has done a pr nobody is allowed to help improving it.

avatar brianteeman
brianteeman - comment - 10 Jan 2021

I didnt ignore it. I just didnt accept it.

Add a Comment

Login with GitHub to post a comment