? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
7 Jan 2021

Pull Request for Issue #30217.

Summary of Changes

The accessibility settings are missing from the profile view of com_admin. This copies those over from the com_users XML.

Testing Instructions

In the backend in the upper right corner click on the user menu and select accessibility settings. Notice that the new page does not contain accessibility settings. Apply the patch, enjoy the new settings.

avatar Hackwar Hackwar - open - 7 Jan 2021
avatar Hackwar Hackwar - change - 7 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jan 2021
Category Administration com_admin Language & Strings
avatar Hackwar Hackwar - change - 7 Jan 2021
The description was changed
avatar Hackwar Hackwar - edited - 7 Jan 2021
avatar Hackwar Hackwar - change - 7 Jan 2021
Title
Adding accessibility settings to admin profile view
[4.0] Adding accessibility settings to admin profile view
avatar Hackwar Hackwar - edited - 7 Jan 2021
avatar ceford
ceford - comment - 8 Jan 2021

I have tested this item successfully on e8004fa

It works. But - It seems that accessibility setting must be on or off for the site by enabling the plugin. It would be much better to enable it by individual user - here.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31884.

avatar ceford ceford - test_item - 8 Jan 2021 - Tested successfully
avatar toivo
toivo - comment - 8 Jan 2021

I have tested this item successfully on e8004fa

Tested successfully in Beta7-dev of 8 January.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31884.

avatar toivo toivo - test_item - 8 Jan 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 8 Jan 2021

It would be much better to enable it by individual user - here.

Why

avatar Hackwar Hackwar - change - 8 Jan 2021
Labels Added: ? ?
avatar ceford
ceford - comment - 8 Jan 2021

It would be much better to enable it by individual user - here.

Why

Did I miss something? Are the Accessibility settings on site-wide for everybody or off for everybody? I just expect it to be a personal option.

avatar chmst
chmst - comment - 8 Jan 2021

These settings are only for backend users and only for the backend.

avatar brianteeman
brianteeman - comment - 8 Jan 2021

It is a personal option if you use the settings.
It is a site owners option if they are available to those backend users (enable/disable the plugin)

Think about it carefully and you will "get it"

avatar wilsonge
wilsonge - comment - 8 Jan 2021

It is a site owners option if they are available to those backend users (enable/disable the plugin)

Not in this case @brianteeman - this PR is dealing with the template settings. It's got nothing to do with the plugin

avatar brianteeman
brianteeman - comment - 8 Jan 2021

Sorry I got confused by @ceford unrelated comment

avatar Quy
Quy - comment - 8 Jan 2021

Is PR #29226 not valid?

avatar Hackwar
Hackwar - comment - 8 Jan 2021

I don't care which PR is used. I want this Release Blocker fixed and right now I would use the quickest way possible. This is not something that we can't change in Joomla 4.1 or later.

avatar wilsonge wilsonge - change - 10 Jan 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-10 01:14:56
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 Jan 2021
avatar wilsonge wilsonge - merge - 10 Jan 2021
avatar wilsonge
wilsonge - comment - 10 Jan 2021

Thanks!

Add a Comment

Login with GitHub to post a comment