Feeling Lucky
?
?
[#31878] - Fix PHP CS errors introduced with PR 31672
- Fixed in Code Base
- 12 Jan 2021
- Medium
- Build: staging
- # 31878
- Diff
- richard67:staging-fix-php-cs-2021-01-07
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Use tabs and not spaces for indentation in PHP files.
Testing Instructions
Code review + check that PHP CS succeeds in Drone tests.
Actual result BEFORE applying this Pull Request
Spaces used for indentation at the end of file layouts/joomla/form/field/password.php.
PHP CS fails in Drone tests.
Expected result AFTER applying this Pull Request
Tabs used for indentation at the end of file layouts/joomla/form/field/password.php.
PHP CS succeeds in Drone tests.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
Quy
- comment
- 7 Jan 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31878.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 7 Jan 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31878.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-12 16:21:48 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
HLeithner
- comment
- 12 Jan 2021
thanks
I have tested this item✅ successfully on e116a82
Tested successfully in 3.9.24-rc2 of 7 January.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31878.