?
avatar brianteeman
brianteeman
5 Jan 2021

In the multilingual associations component there are two delete buttons

image

If you click on delete all you get a confirmation dialog

If you click on delete orphans the action is performed without any further confirmation.

Is that the intended behaviour?

avatar brianteeman brianteeman - open - 5 Jan 2021
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jan 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 5 Jan 2021
avatar infograf768
infograf768 - comment - 5 Jan 2021
$app->enqueueMessage(
			Text::_($count > 0 ? 'COM_ASSOCIATIONS_DELETE_ORPHANS_SUCCESS' : 'COM_ASSOCIATIONS_DELETE_ORPHANS_NONE'),
			'message'
		);
avatar infograf768
infograf768 - comment - 5 Jan 2021

Screen Shot 2021-01-05 at 18 38 45

Screen Shot 2021-01-05 at 18 38 57

avatar brianteeman
brianteeman - comment - 5 Jan 2021

I have absolutely no idea what the meaning of your two posts is other than to confirm what I wrote

avatar chmst
chmst - comment - 5 Jan 2021

@brianteeman you wrote If you click on delete orphans the action is performed without any further confirmation.

@infograf768 posted screens where deleting orphans is confirmed.

Seems that I missed something?

avatar infograf768
infograf768 - comment - 6 Jan 2021

@brianteeman and @gostn

If you click on delete orphans the action is performed without any further confirmation.

We DO have a confirmation as demonstrated above by the code and the screenshots, message depending if there were orphans to delete and deletion occurred or not.

I also wonder, as @chmst does, if I have missed something.
Would it be that you expect a js pop-up confirmation of the action before performing it?
If that is the case, it is totally unnecessary. The action is performed in the same way as Rebuilding menu Items or Rebuilding Update Sites or Deleting Cache or Clearing Update Cache.

avatar brianteeman
brianteeman - comment - 6 Jan 2021

OK it was lost in translation then.

When you click on Delete All Associations you are asked to confirm that you want to do this
image

When you click on Delete Orphans you do not

avatar infograf768 infograf768 - change - 6 Jan 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-01-06 08:53:23
Closed_By infograf768
avatar infograf768 infograf768 - close - 6 Jan 2021
avatar infograf768
infograf768 - comment - 6 Jan 2021

As I said above

If that is the case, it is totally unnecessary. The action is performed in the same way as Rebuilding menu Items or Rebuilding Update Sites or Deleting Cache or Clearing Update Cache.

We never need the choice to stop performing the action.
Closing as not a bug

avatar brianteeman
brianteeman - comment - 7 Jan 2021

We never need the choice to stop performing the action.

Why not. Its a permanent action. How is it different to delete associations?

avatar infograf768
infograf768 - comment - 7 Jan 2021

The only thing it does is clean up db of remains of wrong associations entries. Basically, if one has played with associations and deleted some, one may sometimes have wrong remains. This gets rid of them for ever. It is useless to choose not to.

Add a Comment

Login with GitHub to post a comment