[#31854] - [4.0] Skip-to plugin major upgrade [a11y]
- Closed
- 15 Jan 2021
- Medium
- Build: 4.0-dev
- Draft PR
- # 31854
- Diff
- brianteeman:skipto
User tests: Successful: Unsuccessful:
This is a draft PR to give a heads up about this new version especially as there are new language strings.
Amongst other things it addresses @infograf768 comments about not everything be translatable and an old comment from @clodder about the dropdown script which is no longer being used.
In the process of creating this PR I discovered a few bugs in the upstream code (pr submitted) and that there github is ahead of the release on npm yet with a lower package number.
As a result this PR is not completed and its not working (hence its a draft).
This release is much much better under the hood. I have only implemented some of the features (ie not the important and all distinction) as they're more suitable to a content rich site than an admin ui.
For now you can only do a code review. As soon as I get a response to paypal/skipto#68 I will be able to complete the release
More information http://paypal.github.io/skipto/
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Repository NPM Change Front End Plugins |
| Labels |
Added:
?
NPM Resource Changed
?
|
||
@dgrammatiko thanks for #69 that will really make it much better
As for the module bit, I don't actually have a clue what it does. @Fedik wrote that
Good news is that I have it working locally
Bad news is that they made even more breaking changes and they put them in a patch release. So as soon as that is fixed and they release 4.0 I will be ready
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-15 12:43:20 |
| Closed_By | ⇒ | brianteeman |
@brianteeman fwiw if paypal/skipto#69 is ever gets merged then the whole inline part of the plugin is useless (not to mention that the option type="module" is not doing what you think it does, in sort the plugin will NEVER execute in browsers without module support)