User tests: Successful: Unsuccessful:
Added missing updates table to lines 1750 - 1766, which solves the update issue.
What exactly are you trying to solve how? Quoting the default values is okay, not exactly necessary, but the auto increment should be handled automatically by the DB and not be part of the scheme definition in my opinion. As far as I can see, the change from varchar to text is the only real change, right? Could we limit the PR to that then?
This will cause issues so be sure to not merge it in the current state.
Labels |
Removed:
?
|
Status | New | ⇒ | Pending |
Category | ⇒ | SQL |
Is this still valid?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3185.
Looks like there are merge conflicts too. I'm going to go ahead and close this PR. Could you update to the latest staging and submit a new PR? Within the PR please give some clarification on what you're hoping to achieve, as well as testing instructions.
Thanks!
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-17 04:34:34 |
@RustyIngles Thanks for your PR. Since we are still tracking bugs in our JoomlaCode tracker, may I ask you to open an item there and reference it back here?
And can you also add some notes about which exact issue you mean?