[#31845] - [4.0] Cover cases where the image can't be parsed
- Fixed in Code Base
- 3 Jan 2021
- Medium
- Build: 4.0-dev
- # 31845
- Diff
- wilsonge:image_not_parsable
User tests: Successful: Unsuccessful:
Pull Request for Issue #31837 .
Summary of Changes
Create a custom exception that we can catch to cover cases where images can't be parsed
Testing Instructions
Add an XCF image into your images folder (e.g. https://stendhalgame.org/wiki/File:Sample-column.xcf) that can't be parsed by PHP. Note you can't do this through image manager upload.
Actual result BEFORE applying this Pull Request
No images in the folder will load
Expected result AFTER applying this Pull Request
Images load
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31845.
Yup. It's the same thing that's shown for example when you upload a PDF
i assumed so hence the successful test but wanted to be certain
| Title |
|
||||||
I have tested this item
Works as described. one thought: should the error message be translatable string? I guess not if it is caught and not displayed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31845.
As you say it’s pretty rare our exceptions get displayed to the user - so nope not required here
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31845.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-03 11:33:37 |
| Closed_By | ⇒ | HLeithner | |
| Labels | |||
Thanks
I am assuming that its the expected behaviour that the xcf image that couldnt be parsed is displayed as below
