We really should follow best practice and NOT have links that are just called "here".

Can I suggest something like

PLG_QUICKICON_EOSNOTIFY_CLICK_FOR_INFORMATION_MESSAGE_START=Support for Joomla 3.10 has ended. Please visit
PLG_QUICKICON_EOSNOTIFY_CLICK_FOR_INFORMATION_CLICK_WORD="www.joomla.org"
PLG_QUICKICON_EOSNOTIFY_CLICK_FOR_INFORMATION_MESSAGE_END="for more information."

In addition we are not really providing a good service to our users if we only tell them on the day that support has ended. I would suggest having a progressive series of messages that go from Information to Warning to Error and preferably with an actual date so a user can see something like "will end in 90 days on 1 Nov 2023". I think the code for the php version eol will probably provide you with the suitable code to adopt.

Thanks. Its a draft as we have a meeting in the week to decide on many aspects of the plugin including whether we have dates and whether we want all the message areas. I have updated many aspects of what was there but left the url and text as is. So please dont go too far as this will all change after the meeting in the week

The Warning is not language-aware at all. A sprintf should be used.

A unique string is necessary to cope with that:

PLG_QUICKICON_EOSNOTIFY_CLICK_FOR_INFORMATION_MESSAGE="Joomla 3.10 Support Has Ended. Click <a %s>Here</a> For More Information."

and therefore delete the 3 strings:

PLG_QUICKICON_EOSNOTIFY_CLICK_FOR_INFORMATION_MESSAGE_START="Joomla 3.10 Support Has Ended Click"
PLG_QUICKICON_EOSNOTIFY_CLICK_FOR_INFORMATION_CLICK_WORD="Here"
PLG_QUICKICON_EOSNOTIFY_CLICK_FOR_INFORMATION_MESSAGE_END="for More Information."

Code:

$this->app->enqueueMessage(Text::sprintf('PLG_QUICKICON_EOSNOTIFY_CLICK_FOR_INFORMATION_MESSAGE', 'href="https://www.joomla.org/" target="_blank"'), 'warning');

which gives correctly:

Also It looks like this new string is not used.
PLG_QUICKICON_EOSNOTIFY_MESSAGE="Joomla 3.10 Support Has Ended!!!<br />Click Here for More Information."

@softforge Congratulations on your first PR! Thanks for your service!

The link will go to the same place as the last EOS plugin... docs.joomla.org/Why_Migrate.
As for what I had in mind, I'm going to hold off on answering that part until after the CMS Release Team meets about it this week.

@wilsonge if we send them directly to the 3.10.x to 4.x planning page, then they won't see the self assessment. Or we can add a link to the self assessment to that page. I'll make a comment on the doc in Drive.

@bayareajenn This is true. I guess I was trying to avoid them having to click on the 3.x to 4.x funnel because in this case we should know exactly what version they are going between. I'm not sure. If you think it's better to send them to the main funnel page I'm fine with that too

@bayareajenn This is true. I guess I was trying to avoid them having to click on the 3.x to 4.x funnel because in this case we should know exactly what version they are going between. I'm not sure. If you think it's better to send them to the main funnel page I'm fine with that too

Leaving it to link to the main funnel just removes some risk that they miss some info in those initial pages.

@softforge You have marked my 2nd review about the code style fix as resolved, but you haven't committed that suggestion or any other fix for the code style error, and so drone is still in failed status.

If you unresolve that conversation you can again use a button to apply the suggested change.

What needs to be done to complete this.

I am assuming that this needs to be merged into 3.10 and that makes it a release blocker for 4.0 at the same time.

As it needed the release dates added to make it work it was finished privately and I gave Tobias the finished package about 3-4 weeks ago. He just needs to review and add the comments the testing team made.

Yes its still on my to do to make a PR.

so can this one be closed?

I dont see why not. Tobias? is there any reason to keep it open? If no then please close

#34453