? ? Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
2 Jan 2021

Pull Request for Issue # .

Summary of Changes

Added display: flex for icon and text inside search button, see comment
#31827 (comment)

Testing Instructions

Create a smart search module on the sidebar.
Run npm

Actual result BEFORE applying this Pull Request

The search button is too big

image

Expected result AFTER applying this Pull Request

image

avatar drmenzelit drmenzelit - open - 2 Jan 2021
avatar drmenzelit drmenzelit - change - 2 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jan 2021
Category Front End Templates (site) NPM Change
avatar adj9
adj9 - comment - 2 Jan 2021

I have not tested this item.

I tried installing PR to see the effect. The first installation I got error 500 when accessing /administator.
In the second installation logging into the backend I cannot log in. The _users table in the db is empty.

Only I have these problems with the test of Joomla! with the Patch?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31839.

avatar adj9 adj9 - test_item - 2 Jan 2021 - Not tested
avatar drmenzelit
drmenzelit - comment - 2 Jan 2021

@adj9 how are you installing the patch? Do you have problems with other PRs? This PR changes only a scss file...

avatar adj9
adj9 - comment - 2 Jan 2021

I did an installation of Joomla! for npm on a website (not local). Checking the db I have the empty users table.

It seems strange to me too, the db has nothing to do with the patch!

Before installing the package I emptied the db.

avatar drmenzelit
drmenzelit - comment - 2 Jan 2021

You only need to apply the PR and run npm run build:css to process the changes done in the scss file of the Cassiopeia template.

avatar ceford
ceford - comment - 3 Jan 2021

I have tested this item successfully on 968f2ca

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31839.

avatar ceford ceford - test_item - 3 Jan 2021 - Tested successfully
avatar gostn
gostn - comment - 3 Jan 2021

I have tested this item successfully on 968f2ca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31839.

avatar gostn gostn - test_item - 3 Jan 2021 - Tested successfully
avatar alikon alikon - change - 3 Jan 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 3 Jan 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31839.

avatar infograf768 infograf768 - change - 3 Jan 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-03 08:31:07
Closed_By infograf768
Labels Added: ? ?
avatar infograf768 infograf768 - close - 3 Jan 2021
avatar infograf768 infograf768 - merge - 3 Jan 2021
avatar infograf768
infograf768 - comment - 3 Jan 2021

Thanks!

Add a Comment

Login with GitHub to post a comment