? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Jan 2021

The code that was added to the login module to support the svg icon for webauthn was missing for the users component

Testing Instructions

Compare the login module and the user login menu item in the front end on a site with https

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

avatar brianteeman brianteeman - open - 1 Jan 2021
avatar brianteeman brianteeman - change - 1 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jan 2021
Category Front End com_users
avatar ChristineWk
ChristineWk - comment - 1 Jan 2021

I have tested this item successfully on efc2eda


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31824.

avatar ChristineWk ChristineWk - test_item - 1 Jan 2021 - Tested successfully
avatar gostn
gostn - comment - 2 Jan 2021

I have tested this item successfully on efc2eda


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31824.

avatar gostn gostn - test_item - 2 Jan 2021 - Tested successfully
avatar alikon alikon - change - 2 Jan 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 2 Jan 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31824.

avatar richard67 richard67 - change - 2 Jan 2021
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 2 Jan 2021

The patch works. No problem.
But, if #31545 is merged, then it would have to be modified.

avatar N6REJ
N6REJ - comment - 2 Jan 2021

@infograf768 that depends if #31190 is reverted or not. So now we have 4 issues on hold sigh

avatar brianteeman
brianteeman - comment - 2 Jan 2021

This should be merged as it fixes a problem right now. A new PR can always be created later if needed as a result of any other PR

avatar wilsonge wilsonge - change - 2 Jan 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-02 20:40:39
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 2 Jan 2021
avatar wilsonge wilsonge - merge - 2 Jan 2021
avatar wilsonge
wilsonge - comment - 2 Jan 2021

Thanks!

avatar brianteeman
brianteeman - comment - 2 Jan 2021

thanks

Add a Comment

Login with GitHub to post a comment