User tests: Successful: Unsuccessful:
Pull Request for Issue #31804 .
Refactor the image filter class to have custom namespaces by using a registry for loading classes.
Because there is a poor user experience for third party extensions who'd have to custom autoload code to add custom filters (as evidenced by the fact we were doing this in our own tests until yesterday)
Yup - refactor the namespaced stuff.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Title |
|
Labels |
Added:
?
|
Labels |
Added:
?
Removed: ? |
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.
This pull request has been automatically rebased to 5.1-dev.
Labels |
Added:
Feature
Maintainers Checked
PR-5.0-dev
Removed: ? |
This pull request has been automatically rebased to 5.2-dev.
Title |
|
This pull request has been automatically rebased to 5.3-dev.
Title |
|
Tried to create a custom image and add a custom filter to the Registry of the CustomImage class, which is in another namespace, e.g.
Joomla\CMS\Customimage
This seems to work, but is it intended behavior that the Image class and the CustomImage class share the registry and all their newly registered filters?
Inside a Plugin in /plugins/system/
I also tried to replace the registry of the Image class with a custom Registry in another namespace, The Image class expects the registry to be of type
\Joomla\CMS\Image\ImageFilterRegistry
and therefore it seems no custom registry ( that is in another namespace ) can be provided.Is it intended to not be able to overwrite the Registry of the Image class?
I imaging that my custom registry provides different( e.g. custom filters ) for already existing filter keys like
'brightness' => Filter\CustomBrightness::class,
registry replacement snippet, in which the custom registry provides a custom brightness filter, but fails
Appended the source code for the plugin
imagefiltertest
which could be placed in plugins/system/ and the libraryCustomimage
which could be placed in /libraries/src/imagefiltertest.zip