[#3181] - [#33342] JFormValidator JavaScript class does not scale well
- Closed
- 8 Aug 2014
- Medium
- Build: staging
- # 3181
- Diff
- rmcdaniel:33342
- Foreign ID 33342
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This bug has been confirmed before but the fix was held up with the attempted purge of MooTools in favor of jQuery. I think it's time we visit this again since this is really an annoying bug for lots of people (See: http://forum.joomla.org/viewtopic.php?p=3002410).
Problem: The admin form validation Javascript has a time complexity of O(n^2) and therefore freezes the browser if you have lots of categories or menu items. For small sites with only 10 items, it isn't that noticeable because 10^2 is only 100 iterations but if you have 500 items, it's really bad since 500^2 is 250,000 iterations.
Solution: Precompute label-field associations once per validation attempt instead of per field. Please see forthcoming pull request.
Closed as per the comment on the tracker
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-08 14:25:42 |
Fixed to 3.3-dev branch with 763c69f - you might want to make the same PR for 2.5 though - because obviously we're not using jQuery in 2.5