? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
30 Dec 2020

Pull Request for Issue #30412 .

This is the second attempt after #31782 to fix indexing and searching in finder in J3. Please test. @HLeithner, @alikon

avatar Hackwar Hackwar - open - 30 Dec 2020
avatar Hackwar Hackwar - change - 30 Dec 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2020
Category Administration com_finder Front End
avatar alikon
alikon - comment - 4 Jan 2021

there are still issues

image

avatar Hackwar
Hackwar - comment - 6 Jan 2021

Can you please give information on which Postgres version you are using there?

avatar Hackwar
Hackwar - comment - 6 Jan 2021

And, sorry for asking since you most likely did, but: Did you reindex again?

avatar alikon
alikon - comment - 6 Jan 2021

last test was made on postgresql 12.4 & php 7.4.13
...anyway the postgresql version doesn't really matter, i'm afraid..

i'll recommend you to review #30412 ?

avatar alikon
alikon - comment - 6 Jan 2021

Did you reindex again?

i've tested with the Prebuilt package + sample data, and yes i've reindexed

avatar Hackwar Hackwar - change - 14 May 2021
Labels Added: ?
avatar Hackwar
Hackwar - comment - 14 May 2021

I've reworked the PR and it should be working now. Please test.

avatar Hackwar
Hackwar - comment - 14 May 2021

This should now fix

  1. Indexing of content in Postgres
  2. Search in frontend in Postgres and
  3. Suggestions for Postgres
avatar alikon alikon - test_item - 15 May 2021 - Tested successfully
avatar alikon
alikon - comment - 15 May 2021

I have tested this item successfully on 298b78c

with postgresql 11.7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31809.

avatar richard67
richard67 - comment - 18 May 2021

@Hackwar In the description you wrote:

This is the second attempt after #31782

I guess you meant #31787 .

avatar richard67 richard67 - test_item - 18 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 18 May 2021

I have tested this item successfully on 298b78c

Suggestions work now on PosgreSQL as well as on MySQL.

There is a problem with suggestions not being shown when the search string starts with a capital letter.

But that's common for MySQL and PostgreSQL and so not related to this PR here.

There is PR #33940 to fix that for J4, but it should be fixed for J3, too, I think.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31809.

avatar richard67
richard67 - comment - 18 May 2021

I have tested this item successfully on 298b78c

Suggestions work now on PosgreSQL as well as on MySQL.

There is a problem with suggestions not being shown when the search string starts with a capital letter.

But that's common for MySQL and PostgreSQL and so not related to this PR here.

There is PR #33940 to fix that for J4, but it should be fixed for J3, too, I think.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31809.

avatar richard67 richard67 - change - 18 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 18 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31809.

avatar HLeithner HLeithner - change - 18 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-18 13:27:06
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 18 May 2021
avatar HLeithner HLeithner - merge - 18 May 2021
avatar HLeithner
HLeithner - comment - 18 May 2021

Thanks

avatar HLeithner HLeithner - change - 24 May 2021
Title
Smart Search: Fix indexing for Postgres 2. attempt
Smart Search: Fix indexing for Postgres
avatar HLeithner HLeithner - edited - 24 May 2021

Add a Comment

Login with GitHub to post a comment