[#31805] - [4.0] Rework tags to have a dedicated interface
- Fixed in Code Base
- 31 Dec 2020
- Medium
- Build: 4.0-dev
- # 31805
- Diff
- wilsonge:feature/fix-batch-actions
User tests: Successful: Unsuccessful:
Pull Request for Issue #31127 (and addresses comments made in the original PR #31793) .
I don't like making b/c breaks in functionality this late into the J4 development. But I think this is required before we start wrapping ourselves in circles with workarounds in batch funtionality.
Summary of Changes
Reworks some of tags onto an interface (partly stolen from @Hackwar 's work in #24551 but without some of the larger changes) like we already did with versions.
There's also a new plugin event specifically for batch events that will allow us to to transformations of objects on the data being created. I chose to have a plugin here as the newTag property is kinda internal to the taggable plugin. Whereas the other batch methods can simply use the interface and don't really have any tags logic (other than using for the interface methods)
The new TaggableTableInterface should also allow us to cleanup any other interactions (such as the existing saveorder code).
Testing Instructions
Test tags functionality in all components (articles, categories, contact and newsfeeds). Confirm assigning, removing tags to all these things work. Confirm all still work
Test batch moving items to a new category or language. Before patch tags would get lost, after patch they don't.
Test batch copying items. Before patch tags are not preserved after patch they are.
Documentation Changes Required
Interface and trait needs to be documented. We also should backport them as empty back to the 3.10 release like we did with the versioning
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_contact com_content com_newsfeeds com_tags com_users Libraries Front End Plugins |
| Labels |
Added:
?
|
||
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31805.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31805.
| Labels |
Added:
?
|
||
Needs fresh testing though
I have tested this item
Not sure I have tested all, but for what I tested it works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31805.
| Status | Ready to Commit | ⇒ | Pending |
Don't know why bot set back to RTC as we have only one OK test. Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31805.
I have tested this item
Everything looks good. No issues with functionality of Tags.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31805.
| Status | Pending | ⇒ | Ready to Commit |
Really RTC now :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31805.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-31 22:54:53 |
| Closed_By | ⇒ | bembelimen |
If it breaks, we can blame 2020. Thanks.
I have tested this item✅ successfully on 84d9336
Tested successfully in Beta6-dev of 30 December in PHP 7.4.13. All the copies and moves between categories retained the tags.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31805.