? ?
avatar PhilETaylor
PhilETaylor
18 Dec 2020

Steps to reproduce the issue

In Joomla 3.9.24RC admin -> Edit an article
Images and links tab
Click SELECT to launch the Media Manager to select a new Intro Image

Expected result

Not what I see haha

Actual result

Screen Recording 2020-12-18 at 09 48 02 pm

System information (as much as possible)

Safari on MacOS
PHP 8.0.2-dev

Additional comments

avatar PhilETaylor PhilETaylor - open - 18 Dec 2020
avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Dec 2020
avatar HLeithner
HLeithner - comment - 18 Dec 2020

Can you please check another browser?

avatar PhilETaylor
PhilETaylor - comment - 18 Dec 2020

Its ok on Google Chrome on MacOS

its broken on Safari on iPad
its broken on safari on MacOS

avatar HLeithner
HLeithner - comment - 18 Dec 2020

ok thanks maybe @Fedik can have a look at this?

avatar PhilETaylor
PhilETaylor - comment - 18 Dec 2020

image

avatar infograf768
infograf768 - comment - 19 Dec 2020

same with php 7.x.x ?

avatar infograf768
infograf768 - comment - 19 Dec 2020

I confirm issue with php 7.3.9 Safari Version 12.1.2 (12607.3.10)

avatar infograf768
infograf768 - comment - 19 Dec 2020

We have a style="display: none;" in the select.

Without it we get
Screen Shot 2020-12-19 at 07 29 25

But it is working fine when using the images xtd...

avatar Fedik
Fedik - comment - 19 Dec 2020

I do not have a safari, cannot check, sorry,

We have a style="display: none;" in the select.

Hm, does it use Choosen.js ? Maybe after some safari update that broke this lib.

avatar infograf768
infograf768 - comment - 19 Dec 2020

After multiple tests and trying to modify through console the scss, or quitting Safari, killing session, result tests are not clear. I sometimes get a correct display, sometimes not. Confused...

avatar infograf768
infograf768 - comment - 19 Dec 2020

@Fedik
Screenshots

Screen Shot 2020-12-19 at 10 21 46

Screen Shot 2020-12-19 at 10 22 09

avatar Fedik
Fedik - comment - 19 Dec 2020

yea, it is Choosen.js, hm hm
I suspect it cannot calculate correct size on safari, or something

avatar Fedik
Fedik - comment - 19 Dec 2020

in theory same issue should be in all j3.x.x in safari, because we do not change anything in j3.9.24 for this view

avatar Fedik
Fedik - comment - 19 Dec 2020

@infograf768 to disable choose, just remove this line :)

JHtml::_('formbehavior.chosen', 'select');

avatar infograf768
infograf768 - comment - 19 Dec 2020

Well, not so nice for other browsers.

for both xtd and media field

Safari after change

Screen Shot 2020-12-19 at 11 06 46

Screen Shot 2020-12-19 at 11 07 05

Firefox BEFORE change
Screen Shot 2020-12-19 at 11 08 53

Screen Shot 2020-12-19 at 11 09 09

Firefox AFTER change

Screen Shot 2020-12-19 at 11 08 10

Screen Shot 2020-12-19 at 11 08 25

Chrome after change

Screen Shot 2020-12-19 at 11 15 12

avatar Fedik
Fedik - comment - 19 Dec 2020

Well, not so nice for other browsers.

yeah, I agree

avatar Fedik
Fedik - comment - 19 Dec 2020

maybe @dgrammatiko can have a look, he have safari :)

avatar dgrammatiko
dgrammatiko - comment - 19 Dec 2020

in theory same issue should be in all j3.x.x in safari, because we do not change anything in j3.9.24 for this view

Well, it's not the case for 3.9.23 as I already tested it there. For the RC I have to setup a local env (new PC here) and it will take some time

avatar rdeutz rdeutz - labeled - 20 Dec 2020
avatar rdeutz rdeutz - change - 20 Dec 2020
Labels Added: ?
avatar dgrammatiko
dgrammatiko - comment - 21 Dec 2020

Sorry it seems I can't replicate it either with the latest Safari or Safari Technology Preview on Big Sur
Screenshot 2020-12-21 at 19 12 24
Screenshot 2020-12-21 at 19 12 07

Please clean your cache and clear the history then try again (it might be a hiccup on some css file)

avatar PhilETaylor PhilETaylor - change - 21 Dec 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-12-21 18:19:29
Closed_By PhilETaylor
Labels Added: ?
Removed: ?
avatar PhilETaylor
PhilETaylor - comment - 21 Dec 2020

I replicated it on my iPad and on my iMac, independently...

If no one else can replicate it then no bother.

avatar PhilETaylor PhilETaylor - close - 21 Dec 2020
avatar dgrammatiko
dgrammatiko - comment - 21 Dec 2020

@PhilETaylor you don't have to close it as it could be a legitimate bug. I just d/l the RC and couldn't replicate it. Maybe it needs some specific criteria?

avatar PhilETaylor
PhilETaylor - comment - 21 Dec 2020

Im going to the kids bedroom to use her iMac... its never had Joomla installed. Fingers crossed.

avatar PhilETaylor
PhilETaylor - comment - 21 Dec 2020

Im guessing a width of 2px is not correct...
Screenshot 2020-12-21 at 18 27 56

avatar dgrammatiko
dgrammatiko - comment - 21 Dec 2020

That should be 220px

avatar PhilETaylor
PhilETaylor - comment - 21 Dec 2020

Broken on Firefox on macOS

Screenshot 2020-12-21 at 18 32 51

avatar PhilETaylor
PhilETaylor - comment - 21 Dec 2020

Its a PHP 8 issue. wow...

As soon as I run it in PHP 7.4/7.3/7.2 it works fine...

avatar dgrammatiko
dgrammatiko - comment - 21 Dec 2020

@PhilETaylor I'm also on PHP 8.0 here

avatar PhilETaylor
PhilETaylor - comment - 21 Dec 2020

try running it with the command line php server

php -S 0.0.0.0:80

I can replicate it every time in Firefox and Safari when using that with PHP 8.0.2-dev - but still confused why this is a PHP issue.

avatar PhilETaylor
PhilETaylor - comment - 21 Dec 2020

In fact I lie, my command line is not docker, so its running stable released 8.0.0 and not any funky 8.0.2-dev which I use in docker.

100% replicate-able now, using php -S 0.0.0.0:80 development server with brew installed php 8.0.0

avatar PhilETaylor PhilETaylor - change - 21 Dec 2020
Status Closed New
Closed_Date 2020-12-21 18:19:29
Closed_By PhilETaylor
Labels Added: ?
Removed: ?
avatar PhilETaylor PhilETaylor - reopen - 21 Dec 2020
avatar dgrammatiko
dgrammatiko - comment - 21 Dec 2020
avatar dgrammatiko
dgrammatiko - comment - 21 Dec 2020

*change line 29 to

avatar PhilETaylor
PhilETaylor - comment - 21 Dec 2020

Slightly different as the search icon is brought back on screen

Screenshot 2020-12-21 at 19 13 38

avatar dgrammatiko
dgrammatiko - comment - 21 Dec 2020

@PhilETaylor you might want to step into

public function getFolderList($base = null)

and check the final string returned from here. I'm still unable to reproduce it here, sorry ?‍♂️

avatar PhilETaylor PhilETaylor - change - 17 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-17 15:22:23
Closed_By PhilETaylor
Labels Added: ?
Removed: ?
avatar PhilETaylor PhilETaylor - close - 17 Apr 2021
avatar PhilETaylor
PhilETaylor - comment - 17 Apr 2021

I can no longer replicate this on any browser with staging today. If someone else that used to be able to confirm this, can also see its working today then we can just ignore this issue and close this.

Add a Comment

Login with GitHub to post a comment