[#31701] - Improve error message for broken JSON
- Fixed in Code Base
- 18 Dec 2020
- Medium
- Build: 4.0-dev
- # 31701
- Diff
- wilsonge:fix/wa-registry-error-imp
User tests: Successful: Unsuccessful:
Summary of Changes
The current string for broken JSON in a web asset registry doesn't make much human sense. This fixes it to specifically check for broken JSON and reports on that. As a result we pass things like an empty json file to the next step where we check for the assets to exist. So I've amended the code comment to reflect that
Test Instructions
Part code review. You can also try editing one of the web asset files (e.g. templates/cassiopeia/joomla.asset.json) to contain invalid json and turn on debug mode in the symfony handler (change line 56 in libraries/bootstrap.php to $errorHandler = \Symfony\Component\ErrorHandler\ErrorHandler::register(new Symfony\Component\ErrorHandler\ErrorHandler(null, true));) and view the exception message generated
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31701.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31701.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-18 09:21:29 |
| Closed_By | ⇒ | HLeithner | |
| Labels | |||
Thanks
I have tested this item✅ successfully on f18b6e8
Code review:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31701.