Pending

User tests: Successful: Unsuccessful:

avatar ghost
ghost
20 Aug 2012
  • Added ordering to column titles where it was missing
  • Fixed incorrect icon when ascending
  • Added correctly formatted tooltips to order column titles
  • Fixed classnames on many column titles
  • Fixed ordering on some components
  • Fixed some html issues
  • Made the order direction filter a little wider so the text does not get cut off
avatar nonumber nonumber - open - 20 Aug 2012
avatar infograf768
infograf768 - comment - 21 Aug 2012

Please create a tracker item on joomlacode

avatar nonumber
nonumber - comment - 22 Aug 2012

synced with master (again!)

avatar nonumber
nonumber - comment - 4 Sep 2012

synced with master again

avatar infograf768
infograf768 - comment - 5 Sep 2012

Could you also add a Status column in administrator/index.php?option=com_languages&view=languages

avatar nonumber
nonumber - comment - 5 Sep 2012

This pull request is about adding the sorting (back) to all the available column titles.
Please place new feature requests in new trackers.

avatar infograf768
infograf768 - comment - 5 Sep 2012

fine.
In the mean while, we can't commit this until the pull to platform for
libraries/joomla/html/html/grid.php
is done, as the file is modified.

avatar pjwiseman
pjwiseman - comment - 5 Sep 2012

@nonumber Are you right to create the platform pull, or do you need help with that?

avatar pjwiseman
pjwiseman - comment - 5 Sep 2012

I'm struggling with commit 127c374, the "merge remote tracking branch remotes/upstream/master". I'm hoping someone better versed in joomla's use of git can give that the ok or not ok. When I merge to my own fresh master I get a merge tree that doesn't clearly distinguish the changes in this pull. The merge is valid - it's simply how it is presented. When refreshing to the current master, I generally do a rebase, create a new pull request, and close the old one, which is a pain. I don't know whether there is a cleaner way - we're all new to git.

UPDATE: The word is that the upstream merge is ok. This history isn't necessarily as clean, but it works.

avatar nonumber
nonumber - comment - 5 Sep 2012

Thanks Peter,

Changed the grid method to take the tooltip title as extra value:
nonumber@ca0cc44

Rouven is aware of the differences between platform files (bootstrap stuff) and he is on it...
There are more than just these changes that still have to get ported to platform.

avatar nonumber
nonumber - comment - 6 Sep 2012

Has been merged into master: Close

avatar nonumber nonumber - close - 6 Sep 2012

Add a Comment

Login with GitHub to post a comment