[#31699] - [4.0] Fix mail template not found error
- Fixed in Code Base
- 27 Dec 2020
- Medium
- Build: 4.0-dev
- # 31699
- Diff
- wilsonge:feature/mail-template-404
User tests: Successful: Unsuccessful:
Pull Request for Issue #30956 .
Summary of Changes
Fixes logic when the table has no error queued up because nothing went wrong - there's just no entry and adds an additional string to reflect that case.
Testing Instructions
Force a mail template url that doesn't exist JROOT/administrator/index.php?option=com_mails&view=template&layout=edit&template_id=NOSUCH&language=en-GB
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
It does. Strictly this is because we load the item then we load the form (which internally loads the item to bind the data). Iām not sure of a good fix other than something like only loading the form if the item loads successfully. That is also noted in the text above the screenshot ;)
| Title |
|
||||||
Sorry - wrote my comment before coffee. Sure someone will report it as a bug eventually
| Labels |
Added:
?
?
|
||
Refactored. I tested again this morning and realised I couldn't create a mail template after this change - I guess that's what comes of testing things at 5am :) This now has a single error message and is more consistent with other components
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31699.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31699.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-27 01:05:26 |
| Closed_By | ⇒ | wilsonge |
Thanks guys!
In your screenshot it shows the error twice?