? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
16 Dec 2020

The lib_joomla.ini contains a lot of JLIB_DATABASE_ERROR strings which are nowhere used in code. That is just unneeded translator work.
There are also some strings where the class was injected, but the method was part of the string. The method itself shouldn't be translated. This PR adds a new generic string where the method and error message is injected.
In the nested table class, there is a function which requires an error message, but never uses it. I've changed the method so the argument is optional and removed the error messages. The strings used wouldn't work as error message anyway since they expect a parameter.

Summary of Changes

  • The unused strings are removed from the INI files.
  • JLIB_DATABASE_ERROR_MOVE_FAILED and JLIB_DATABASE_ERROR_DELETE_FAILED and are changed to the new generic JLIB_DATABASE_ERROR_METHOD_FAILED
  • The function _runQuery in libraries/src/Table/Nested.php was changed to have an optional error message instead of required. The messages strings are removed.
  • As a bonus, the language class now uses the correct (existing) string for when the SEF code is already present.

Testing Instructions

As with the other PRs, it's hard to actually test this. Code review should do.
You can try to see if the strings are indeed not used in the CMS.

Documentation Changes Required

None

avatar Bakual Bakual - open - 16 Dec 2020
avatar Bakual Bakual - change - 16 Dec 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Dec 2020
Category Administration Language & Strings Installation Libraries
avatar Bakual
Bakual - comment - 16 Dec 2020

Statistic: 38 unused strings are removed, two are replaced by a new one. Not that bad I think ?

avatar Bakual Bakual - change - 16 Dec 2020
Labels Added: ? ?
avatar RickR2H RickR2H - test_item - 24 Apr 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 24 Apr 2021

I have tested this item successfully on c181936

Checked all the removed language strings with a global search trough the system. It appears all the removed strings are not used anymore is the system. Thanks for the cleanup!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31674.

avatar drmenzelit drmenzelit - test_item - 7 Jun 2021 - Tested successfully
avatar drmenzelit
drmenzelit - comment - 7 Jun 2021

I have tested this item successfully on c181936

Searched for removed strings and found only in ini files.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31674.

avatar brianteeman
brianteeman - comment - 12 Jul 2021

Is there any reason that this is not merged? It has two successful tests and it would be a shame for it to miss the language freeze


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31674.

avatar Bakual
Bakual - comment - 3 Aug 2021

Since we are now in language freeze, I'm closing this PR.

avatar Bakual Bakual - close - 3 Aug 2021
avatar Bakual Bakual - change - 3 Aug 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-08-03 15:08:04
Closed_By Bakual

Add a Comment

Login with GitHub to post a comment