User tests: Successful: Unsuccessful:
The lib_joomla.ini
contains a lot of JLIB_DATABASE_ERROR strings which are nowhere used in code. That is just unneeded translator work.
There are also some strings where the class was injected, but the method was part of the string. The method itself shouldn't be translated. This PR adds a new generic string where the method and error message is injected.
In the nested table class, there is a function which requires an error message, but never uses it. I've changed the method so the argument is optional and removed the error messages. The strings used wouldn't work as error message anyway since they expect a parameter.
JLIB_DATABASE_ERROR_MOVE_FAILED
and JLIB_DATABASE_ERROR_DELETE_FAILED
and are changed to the new generic JLIB_DATABASE_ERROR_METHOD_FAILED
_runQuery
in libraries/src/Table/Nested.php was changed to have an optional error message instead of required. The messages strings are removed.As with the other PRs, it's hard to actually test this. Code review should do.
You can try to see if the strings are indeed not used in the CMS.
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings Installation Libraries |
Labels |
Added:
?
?
|
I have tested this item
Checked all the removed language strings with a global search trough the system. It appears all the removed strings are not used anymore is the system. Thanks for the cleanup!
I have tested this item
Searched for removed strings and found only in ini files.
Is there any reason that this is not merged? It has two successful tests and it would be a shame for it to miss the language freeze
Since we are now in language freeze, I'm closing this PR.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-03 15:08:04 |
Closed_By | ⇒ | Bakual |
Statistic: 38 unused strings are removed, two are replaced by a new one. Not that bad I think?