[#31655] - [4.0] Language Install button [a11y]
- Fixed in Code Base
- 18 Dec 2020
- Medium
- Build: 4.0-dev
- # 31655
- Diff
- brianteeman:install_lang
User tests: Successful: Unsuccessful:
On the install languages page every language has an identically named button. Just as you wouldnt have more than one link with the same name you shouldnt have more than one button.
This PR adds an aria-label to each button with the value of "Install "
To test apply pr and view source and you will see the aria-label
(cc @carcam as agreed but you dont seem to be replying)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Labels |
Added:
?
|
||
Tested rtl. Needs to place $language->name before the Text()
<?php if ($lang->isRtl()) : ?> etc.
Can it be a sprintf?
| Category | Administration com_installer | ⇒ | Administration com_installer Language & Strings |
Updated with new code to use sprintf so that it doesnt matter what order the verb and the noun are
Looks fine
I have tested this item
Tested successfully in Beta6-dev of 17 December. RTL not tested.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31655.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31655.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31655.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-18 19:36:54 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
?
|
||
thanks
Is RTL OK ?