Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31628] - [3.9][com_admin] warning in Edit Account

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
10 Dec 2020

Pull Request for Issue #31610 .

Summary of Changes

added key exist check

Testing Instructions

Go to System - Control Panel.
Click Super User – Edit Account.
Go to any tab, for example User Profile and edit something, then click Save.
Or do not change anything and click Save.

Actual result BEFORE applying this Pull Request

Message displayed: 0 Cannot access offset of type string on string

Expected result AFTER applying this Pull Request

No warnings or errors.

a4a96f1 10 Dec 2020 avatar alikon php 8
avatar alikon alikon - open - 10 Dec 2020
avatar alikon alikon - change - 10 Dec 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Dec 2020
Category ⇒ Administration com_admin
avatar gostn
gostn - comment - 10 Dec 2020

@SharkyKZ why thumbs down?

avatar toivo
toivo - comment - 10 Dec 2020

@alikon PHP 8.0.0 reports the variable $data

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31628.

avatar toivo
toivo - comment - 10 Dec 2020

@alikon PHP 8.0.0 reports that the variable $data is not an array, even though var_dump($data) shows that it is an array. This is probably some teething problem in an early version of PHP 8.

The following modification allowed the profile data to be saved correctly:

	if (is_array($data) && array_key_exists('twofactor', (array) $data) && array_key_exists('method', (array) $data['twofactor']))

I have not tested any profile with two-factor authentication configured.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31628.

avatar alikon alikon - change - 11 Dec 2020
Labels Added: ? ?
avatar toivo toivo - test_item - 11 Dec 2020 - Tested successfully
avatar toivo
toivo - comment - 11 Dec 2020

I have tested this item ✅ successfully on 98872a1

Tested successfully in 3.9.23.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31628.

avatar gostn gostn - test_item - 11 Dec 2020 - Tested successfully
avatar gostn
gostn - comment - 11 Dec 2020

I have tested this item ✅ successfully on 98872a1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31628.

avatar jwaisner jwaisner - change - 12 Dec 2020
Status Pending ⇒ Ready to Commit
avatar jwaisner
jwaisner - comment - 12 Dec 2020

Drone Error is not related to PR.

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31628.

avatar jwaisner
jwaisner - comment - 12 Dec 2020

Drone Error is not related to PR.

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31628.

avatar infograf768
infograf768 - comment - 12 Dec 2020

restarted drone

avatar HLeithner
HLeithner - comment - 12 Dec 2020

@alikon please update your pr and both tests (@toivo and @gostn ) are invalid and have to be redone (after changing the PR)

avatar jwaisner jwaisner - change - 13 Dec 2020
Status Ready to Commit ⇒ Pending
avatar jwaisner
jwaisner - comment - 13 Dec 2020

Moving back to Pending for PR changes. Clearing test results as the changes will require retest.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31628.

avatar jwaisner jwaisner - alter_testresult - 13 Dec 2020 - gostn: Not tested
avatar jwaisner jwaisner - alter_testresult - 13 Dec 2020 - toivo: Not tested
avatar toivo toivo - test_item - 13 Dec 2020 - Tested successfully
avatar toivo
toivo - comment - 13 Dec 2020

I have tested this item ✅ successfully on 7b4ab73

Tested successfully in 3.9.24-dev of 13 December.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31628.

avatar gostn gostn - test_item - 13 Dec 2020 - Tested successfully
avatar gostn
gostn - comment - 13 Dec 2020

I have tested this item ✅ successfully on 7b4ab73

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31628.

avatar alikon alikon - change - 13 Dec 2020
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 13 Dec 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31628.

avatar HLeithner HLeithner - change - 13 Dec 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-12-13 13:52:06
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 13 Dec 2020

Thanks

avatar PhilETaylor
PhilETaylor - comment - 18 Dec 2020

Tested 3.9.24RC. All ok.

Add a Comment

Login with GitHub to post a comment