Feeling Lucky
?
?
[#31624] - [4.0] Fix banner module
- Fixed in Code Base
- 11 Dec 2020
- Medium
- Build: 4.0-dev
- Easy Test
- # 31624
- Diff
- chmst:banner-module-fix
User tests: Successful: Unsuccessful:
Pull Request for Issue #31623 .
Summary of Changes
Fix bannerHelper for new media.
credits @drmenzelit
Testing Instructions
see #31623
Actual result BEFORE applying this Pull Request
Images don't pass the isImage check and no image appears.
Expected result AFTER applying this Pull Request
Images are displayed
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners |
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-09 18:53:30 |
| Closed_By | ⇒ | chmst |
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-12-09 18:53:30 | ⇒ | |
| Closed_By | chmst | ⇒ |
| Status | New | ⇒ | Pending |
chmst
- comment
- 9 Dec 2020
Improved the check isImage by splitting the image url
toivo
- comment
- 9 Dec 2020
I have tested this item
Tested successfully in Beta6-dev of 9 December.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31624.
chmst
- comment
- 9 Dec 2020
Question:
The Helper also contains a method isFlash($url) - do we rneed this now in 2020?
| Category | Front End com_banners | ⇒ | Front End com_banners Modules |
ChristineWk
- comment
- 9 Dec 2020
I have tested this item
and check of removed flashplayer
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31624.
gostn
- comment
- 10 Dec 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31624.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 10 Dec 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31624.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-11 13:06:22 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
|
||
drmenzelit
- comment
- 11 Dec 2020
Thanks
This is no appropriate solution