Feeling Lucky
?
[#31606] - [4.0] Media manager icons
- Fixed in Code Base
- 7 Dec 2020
- Medium
- Build: 4.0-dev
- # 31606
- Diff
- brianteeman:media
User tests: Successful: Unsuccessful:
When the media manager is in list view it uses css data-type to generate an appropriate icon.
However the current code only matches lowercase file extensions. This PR make it case insensitive.
To test upload an image with an uppercase filetype eg _DSC1234.JPG and go to the lust view and you will see there is no icon.
Apply this pr and run npm ci and refresh and now you have an icon
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change |
gostn
- comment
- 7 Dec 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31606.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 7 Dec 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31606.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-07 08:23:44 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
infograf768
- comment
- 7 Dec 2020
tks
brianteeman
- comment
- 7 Dec 2020
thanks
I have tested this item✅ successfully on 5ec483d
See https://www.w3.org/TR/selectors-4/#attribute-case for explanation of the use of
iThis comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31606.