? No Code Attached Yet
avatar B3nito
B3nito
30 Nov 2020

Is your feature request related to a problem? Please describe.

When you are a enduser and use an editor and plugin settings is filtering input then html is just stripping out of text.

Describe the solution you'd like

User should get notification that html was cleaning for plugin settings so better usability

Additional context

I have problem in custom fields that filter is enabled default and user thought that Joomla is buggy. User should know what system is do automatically.

avatar B3nito B3nito - open - 30 Nov 2020
avatar joomla-cms-bot joomla-cms-bot - change - 30 Nov 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 30 Nov 2020
avatar HLeithner HLeithner - change - 8 Jan 2021
Labels Added: ?
avatar HLeithner HLeithner - labeled - 8 Jan 2021
avatar Ayushsunny
Ayushsunny - comment - 18 Mar 2021

Is this issue still persist?

avatar pank1999
pank1999 - comment - 19 Mar 2021

i want to solve this issue please guide me

avatar Nitesh639
Nitesh639 - comment - 23 Mar 2021

I want to solve this issue.

avatar Yash-g17
Yash-g17 - comment - 25 Mar 2021

@HLeithner I'd love to work on this issue , can you please assign and guide me ?

avatar brianteeman
brianteeman - comment - 25 Mar 2021

The Joomla Project doesn't assign issues to contributors in that way. Just work on it and submit a PR :-)

https://github.com/joomla/joomla-cms/blob/staging/.github/CONTRIBUTING.md

avatar Ayushsunny
Ayushsunny - comment - 26 Mar 2021

The Joomla Project doesn't assign issues to contributors in that way. Just work on it and submit a PR :-)

https://github.com/joomla/joomla-cms/blob/staging/.github/CONTRIBUTING.md

is there any mentor who can help us to solve this issue?

avatar abhijha0602
abhijha0602 - comment - 26 Mar 2021

I want to solve this issue

avatar sandramay0905
sandramay0905 - comment - 26 Mar 2021

Just work on it and submit a PR :-)

avatar imtiyaj786
imtiyaj786 - comment - 31 Mar 2021

how can i check this issue in own ?

avatar ReLater
ReLater - comment - 31 Mar 2021

Hello volunteers,

  • You don't have to ask if you are allowed to take over an issue.
    • Try to find a code solution for the issue after you have checked whether it really exists.
    • If it exists confirm it here in the issue for the sake of completeness. A "I'll take over" is a good hint for others that don't waste their time then with it.
    • Test your solution.
    • Finally provide a pull request on GitHub (= "here") that others can test. If tests are not successful you can change and discuss your pull request for further tests.
    • Sometimes others provide a "suggestion" that you can merge directly by clicking in your PR.
  • There are no mentors to accompany you. It goes without saying that you can ask the general public how this or that works. I think (don't know) that the "Discussions" tab above can be a good place for more general questions.
  • Here is a doc how to create pull requests via browser GUI: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
  • If you want to go deeper you could also work with a git repository tool on your local machine. Needs some more skills and time to learn:
avatar amankothiyal04
amankothiyal04 - comment - 4 Apr 2021

hey @B3nito can you help me with this issue want to contribute to solve it

avatar Shaveetha
Shaveetha - comment - 8 Apr 2021

I would like to solve this issue. Can you please guide me.

avatar brianteeman
brianteeman - comment - 8 Apr 2021

@Shaveetha @amankothiyal04

Hello volunteers,

  • You don't have to ask if you are allowed to take over an issue.
    • Try to find a code solution for the issue after you have checked whether it really exists.
    • If it exists confirm it here in the issue for the sake of completeness. A "I'll take over" is a good hint for others that don't waste their time then with it.
    • Test your solution.
    • Finally provide a pull request on GitHub (= "here") that others can test. If tests are not successful you can change and discuss your pull request for further tests.
    • Sometimes others provide a "suggestion" that you can merge directly by clicking in your PR.
  • There are no mentors to accompany you. It goes without saying that you can ask the general public how this or that works. I think (don't know) that the "Discussions" tab above can be a good place for more general questions.
  • Here is a doc how to create pull requests via browser GUI: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
  • If you want to go deeper you could also work with a git repository tool on your local machine. Needs some more skills and time to learn:
avatar brianteeman
brianteeman - comment - 25 Apr 2021

Can you please remove the "good first issue label" as its absolutely not a simple thing to fix (not sure if its even possible)

avatar HLeithner
HLeithner - comment - 25 Apr 2021

I don't think it's too hard.

I would solve this issue with 5 lines of code (without looking in deep, only looked at com_content)

Adding $original = $text at this position: https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Component/ComponentHelper.php#L126

And a if ($text !== $original) { JFactory::getApplication()->enqueueMessage('JHTML_FILTER_MODIFY', CMSApplicationInterface::MSG_WARNING); } at line https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Component/ComponentHelper.php#L295

Of course the language string have to be added too. But maybe I think too simple and missed something ymmv

avatar brianteeman
brianteeman - comment - 25 Apr 2021
  1. That won't work for text filtering where the editor eg tinymce is doing the filtering
  2. To be useful it really should say what has been filtered
avatar HLeithner
HLeithner - comment - 25 Apr 2021
  1. is not possible (at least I can't think of a working solution)

  2. I'm pretty sure there is a way to achieve this for tinymce in js too

avatar brianteeman
brianteeman - comment - 25 Apr 2021

Its still not a "good first issue" which was the point of my post

avatar HLeithner
HLeithner - comment - 25 Apr 2021

Why not? it's easy to fix, the first parts are only 5 lines of code.

What would you say what's a good first issue is, If you find one I would really like to tag it.

avatar brianteeman
brianteeman - comment - 25 Apr 2021

If it was so easy then any one of the 10 people who said they wanted to fix it would have been able to or anyone else for that matter in the months since november. plus if its really so easy then you would have submitted it instead of debating a pointless argument with me.

avatar teekhandekar
teekhandekar - comment - 25 Mar 2022

@brianteeman Can I work on this ?

avatar adithyareddych
adithyareddych - comment - 28 Mar 2022

@brianteeman Can I work on this issue?

avatar anshumaan255
anshumaan255 - comment - 30 Jul 2022

is this issue still open want to work on it

avatar Franzwohlkoenig
Franzwohlkoenig - comment - 30 Jul 2022
avatar dv2202
dv2202 - comment - 4 Dec 2022

Hey,@B3nito
Can i work on this issue ?

avatar joomdonation
joomdonation - comment - 4 Dec 2022

@dv2202 No need to ask. See #31540 (comment) for more details.

avatar YashSalve695
YashSalve695 - comment - 9 Jan 2023

can you please assign me this issue?

avatar kushvahasumit
kushvahasumit - comment - 10 Jan 2023

i also want to contribute for this one.

avatar farmannaseem
farmannaseem - comment - 12 Jan 2023

I wanna work on this issue please assign me this issue i would like to contribute in it

avatar chmst chmst - change - 12 Jan 2023
Labels Added: No Code Attached Yet
Removed: ? ?
avatar chmst chmst - unlabeled - 12 Jan 2023
avatar Hackwar Hackwar - change - 20 Feb 2023
Labels Added: ?
avatar Hackwar Hackwar - labeled - 20 Feb 2023

Add a Comment

Login with GitHub to post a comment