? ? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
30 Nov 2020

Pull Request for Issue #31483 .

Summary of Changes

php 8 compatibility

Testing Instructions

use php 8
go to Admin->Control Panel

Actual result BEFORE applying this Pull Request

Warning: FOFModelBehavior::onBeforeBuildQuery(): Argument #1 ($model) must be passed by reference, value given in \libraries\fof\utils\observable\event.php on line 63

Expected result AFTER applying this Pull Request

no warning

201b1dc 30 Nov 2020 avatar alikon php 8
e050d05 30 Nov 2020 avatar alikon php 8
avatar alikon alikon - open - 30 Nov 2020
avatar alikon alikon - change - 30 Nov 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Nov 2020
Category External Library Libraries
avatar 810 810 - test_item - 30 Nov 2020 - Tested successfully
avatar 810
810 - comment - 30 Nov 2020

I have tested this item successfully on e050d05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31537.

avatar gostn gostn - test_item - 1 Dec 2020 - Tested successfully
avatar gostn
gostn - comment - 1 Dec 2020

I have tested this item successfully on e050d05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31537.

avatar alikon alikon - change - 1 Dec 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 1 Dec 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31537.

avatar richard67 richard67 - change - 1 Dec 2020
Labels Added: ? ? ?
avatar jameswadsworth jameswadsworth - test_item - 3 Dec 2020 - Tested successfully
avatar jameswadsworth
jameswadsworth - comment - 3 Dec 2020

I have tested this item successfully on e050d05

This resolves the issue in php 7.4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31537.

avatar HLeithner
HLeithner - comment - 4 Dec 2020

can you please add the modified doc block to both files?

* @note This file has been modified by the Joomla! Project and no longer reflects the original work of its author.

19e61bb 4 Dec 2020 avatar alikon note
avatar alikon alikon - change - 4 Dec 2020
Labels
e87bc54 4 Dec 2020 avatar alikon note
avatar alikon
alikon - comment - 4 Dec 2020

yes, done

avatar HLeithner HLeithner - change - 4 Dec 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-12-04 16:13:39
Closed_By HLeithner
avatar HLeithner HLeithner - close - 4 Dec 2020
avatar HLeithner HLeithner - merge - 4 Dec 2020
avatar HLeithner
HLeithner - comment - 4 Dec 2020

Thanks

avatar SharkyKZ
SharkyKZ - comment - 4 Dec 2020

This shouldn't have been merged.

avatar Fedik
Fedik - comment - 6 Dec 2020

@SharkyKZ what alternative for this can be?

avatar Fedik
Fedik - comment - 6 Dec 2020

but I agree with @SharkyKZ , the changes here will lead to Fatal Error to whose extend the class, with error
Declaration of ' ' must be compatible with ' '

avatar Fedik
Fedik - comment - 6 Dec 2020

I have revert it, and made a better fix, please test #31600

avatar HLeithner
HLeithner - comment - 12 Dec 2020

@810 can you test the new version of this pr at #31600 please?

Add a Comment

Login with GitHub to post a comment