Success

User tests: Successful: Unsuccessful:

avatar AlexanderMeier
AlexanderMeier
20 Feb 2014

Cosmetic change for consistence and avoidance of duplicate URLs.
See also this Bug report: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=25616&start=0
Before change $limitstart was deleted if present, except if it was 0 (zero), because 0 evaluates to false.

avatar AlexanderMeier AlexanderMeier - open - 20 Feb 2014
avatar Bakual
Bakual - comment - 5 Jun 2014

After applying this patch, I get a lot of "Notice: Undefined variable: limistart in /.../libraries/cms/router/site.php on line 594"

@AlexanderMeier Can you please fix that typo? :smile:

Also, this PR is targeted at an old branch which we are going to delete soon. I'm going to close this PR due to that.
Please create a new PR against staging and update the tracker item with the new (fixed) PR.

Thanks for your work!

avatar Bakual Bakual - change - 5 Jun 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-06-05 08:43:39
avatar Bakual Bakual - change - 5 Jun 2014
Title
Delete URL-Parameter limitstart, if its value is 0
[#25616] Delete URL-Parameter limitstart, if its value is 0
avatar Bakual Bakual - close - 5 Jun 2014
avatar Bakual Bakual - close - 5 Jun 2014
avatar AlexanderMeier AlexanderMeier - change - 5 Jun 2014
Title
Delete URL-Parameter limitstart, if its value is 0
[#25616] Delete URL-Parameter limitstart, if its value is 0
avatar Bakual
Bakual - comment - 6 Jun 2014

For reference, new one is #3725

Add a Comment

Login with GitHub to post a comment