[#31474] - [4.0] fix obsolete underlined whitespace in link
- Fixed in Code Base
- 26 Nov 2020
- Medium
- Build: 4.0-dev
- # 31474
- Diff
- hans2103:feature/#31466-add-space-on-menu-item-alias
User tests: Successful: Unsuccessful:
Pull Request for Issue #31466 .
Summary of Changes
This PR will fix the obsolete underlined space in the menu item link when selecting one on creation of a menu item alias.
The same solution is applied as used on the com_menus/items
joomla-cms/administrator/components/com_menus/views/items/tmpl/default.php
Lines 188 to 189 in bfe4fc6
Testing Instructions
- Joomla 4.0-dev with at least one configured menu item.
- Create a new menu item of type
System Links > Menu Item Alias - Press button
Selecton field = Menu Item - A modal popup appears where you can select a menu item
- See the result and compare it with BEFORE
- apply this pr and repeat the steps above
- See the result and compare it with ATER
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Title |
|
||||||
I suggest to rather use the same code format as in default.php by moving the closing </a> to the line above, i.e.
diff --git a/administrator/components/com_menus/tmpl/items/modal.php b/administrator/components/com_menus/tmpl/items/modal.php
index 02689b4..50ec12f 100644
--- a/administrator/components/com_menus/tmpl/items/modal.php
+++ b/administrator/components/com_menus/tmpl/items/modal.php
@@ -115,6 +115,5 @@
<?php if (!$uselessMenuItem) : ?>
<a class="select-link" href="javascript:void(0)" data-function="<?php echo $this->escape($function); ?>" data-id="<?php echo $item->id; ?>" data-title="<?php echo $this->escape($item->title); ?>" data-uri="<?php echo 'index.php?Itemid=' . $item->id; ?>" data-language="<?php echo $this->escape($language); ?>">
- <?php echo $this->escape($item->title); ?>
- </a>
+ <?php echo $this->escape($item->title); ?></a>
<?php else : ?>
<?php echo $this->escape($item->title); ?>
to get
<a class="select-link" href="javascript:void(0)" data-function="<?php echo $this->escape($function); ?>" data-id="<?php echo $item->id; ?>" data-title="<?php echo $this->escape($item->title); ?>" data-uri="<?php echo 'index.php?Itemid=' . $item->id; ?>" data-language="<?php echo $this->escape($language); ?>">
<?php echo $this->escape($item->title); ?></a>
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31474.
@infograf768 that is what I did... moving the closing </a> directly after <?php echo $this->escape($item->title); ?>.
Can you point me the difference?
OOPPS, sorry, confusion here due to old age and home lockdown...
Patch is fine.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31474.
restarted drone
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-26 14:38:29 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
This problem is actual in the latest version of Joomla 4.
Just go to create a new menu item > articles and get a popup window with list of articles and there is such a space in the link.
You have identified a valid issue but it is nothing to do with the issue here. please create a new report
I have tested this item✅ successfully on b30be68
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31474.