?
avatar joeforjoomla
joeforjoomla
23 Nov 2020

Steps to reproduce the issue

Joomla 4.0 Beta 6 dev

Expected result

Font awesome icons CSS are correct

Actual result

All icons are gone and broken with wrong character and encoding

image

avatar joeforjoomla joeforjoomla - open - 23 Nov 2020
avatar joomla-cms-bot joomla-cms-bot - change - 23 Nov 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 23 Nov 2020
avatar chmst
chmst - comment - 23 Nov 2020

Could you please change the title of your issue so that it is more precise.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31470.

avatar joeforjoomla joeforjoomla - change - 23 Nov 2020
Title
[4.0] What damn is this?
[4.0] What damn is this? Font Awesome icons are all broken
avatar joeforjoomla joeforjoomla - edited - 23 Nov 2020
avatar HLeithner HLeithner - change - 23 Nov 2020
Title
[4.0] What damn is this? Font Awesome icons are all broken
[4.0] Font Awesome icons are all broken
avatar HLeithner HLeithner - edited - 23 Nov 2020
avatar N6REJ
N6REJ - comment - 24 Nov 2020

Instead of showing part of a file that you dont understand please show exactly where it's broken. Show me a use case.
Ty


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31470.

avatar joeforjoomla
joeforjoomla - comment - 24 Nov 2020

@N6REJ Bear what do you mean that i don't understand? What damn are you saying?
Don't you see that all icons have lost the correct 'content' value?

Example Beta 5: .icon-checkmark:before,.icon-file-check:before,.icon-ok:before,.icon-publish:before{content:"\f00c"}
Beta 6: .icon-checkmark:before{content:""}.icon-checkmark-2:before,.icon-checkmark-circle:before{content:""}

There are all badly encoded characters: 

avatar brianteeman
brianteeman - comment - 24 Nov 2020

@joeforjoomla I tested the current branch and ran npm i - no problem. I downloaded last nights build - no problem. I compared the file from the build to the one I created with the script - no problem

avatar joeforjoomla
joeforjoomla - comment - 24 Nov 2020

@brianteeman i just downloaded the build 1 minute ago https://developer.joomla.org/nightlies/Joomla_4.0.0-beta6-dev-Development-Full_Package.zip
And the file is broken there

avatar brianteeman
brianteeman - comment - 24 Nov 2020

That's the same file I used with no problem

avatar joeforjoomla
joeforjoomla - comment - 24 Nov 2020

I even updated on a live server to beta 6 and the problem is still the same... file broken.

avatar brianteeman
brianteeman - comment - 24 Nov 2020

Brand new install on a clean server using the nightly zip

image

avatar brianteeman
brianteeman - comment - 24 Nov 2020

image

avatar joeforjoomla
joeforjoomla - comment - 24 Nov 2020

@brianteeman how is it possible that for me the file has no content values? the zip should be the same for everyone isn't it? Additionally the live update should be the same.

avatar joeforjoomla
joeforjoomla - comment - 24 Nov 2020

@brianteeman i'm seeing that only certain icons are not displaying.... for example not working:
image
working:
image

avatar joeforjoomla
joeforjoomla - comment - 24 Nov 2020

And this is the value that is used fo the 'content'
image

avatar joeforjoomla
joeforjoomla - comment - 24 Nov 2020

Should not be regular 'content' as in the original FontAwesome file and as it has always been?
image

avatar brianteeman
brianteeman - comment - 24 Nov 2020

image

image

avatar brianteeman
brianteeman - comment - 24 Nov 2020

Maybe there is something here https://fontawesome.com/changelog/latest

avatar joeforjoomla
joeforjoomla - comment - 24 Nov 2020

Ok i think the problem was the font-weight override not the content value. My fault.
Can you please explain why in the Joomla file there is not the regular content value such as \f5oe but a squared question mark?

Why not this?
image

avatar joeforjoomla
joeforjoomla - comment - 24 Nov 2020

image

avatar C-Lodder
C-Lodder - comment - 24 Nov 2020

The "encoding" issue you see is due to the PR I made to move Joomla from node-sass to dart-sass: #31290

As far as I can tell, it doesn't have an effect on the rendered icons.

Compiling the data as opposed to the actual files may overcome this, but then you've got the @import hell that comes with it.
Else you can revert the PR and update to the latest version of node-sass, however it's deprecated

avatar brianteeman
brianteeman - comment - 24 Nov 2020

Thanks for the explanation

avatar joeforjoomla
joeforjoomla - comment - 24 Nov 2020

Thanks for the explanation and to inform us. Not sure where we should go here.

avatar joeforjoomla joeforjoomla - change - 24 Nov 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-11-24 15:03:54
Closed_By joeforjoomla
avatar joeforjoomla joeforjoomla - close - 24 Nov 2020
avatar N6REJ
N6REJ - comment - 24 Nov 2020

Next time instead of ranting @ me et al perhaps you could explain your viewpoint. I would've explained that thats a failure of dart. I hate it too


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31470.

avatar joeforjoomla
joeforjoomla - comment - 24 Nov 2020

@N6REJ Bear you right, sorry for this and i apologize for the misunderstanding.

Add a Comment

Login with GitHub to post a comment