Labels |
Added:
?
|
Title |
|
Title |
|
Instead of showing part of a file that you dont understand please show exactly where it's broken. Show me a use case.
Ty
@N6REJ Bear what do you mean that i don't understand? What damn are you saying?
Don't you see that all icons have lost the correct 'content' value?
Example Beta 5: .icon-checkmark:before,.icon-file-check:before,.icon-ok:before,.icon-publish:before{content:"\f00c"}
Beta 6: .icon-checkmark:before{content:""}.icon-checkmark-2:before,.icon-checkmark-circle:before{content:""}
There are all badly encoded characters:
@joeforjoomla I tested the current branch and ran npm i - no problem. I downloaded last nights build - no problem. I compared the file from the build to the one I created with the script - no problem
@brianteeman i just downloaded the build 1 minute ago https://developer.joomla.org/nightlies/Joomla_4.0.0-beta6-dev-Development-Full_Package.zip
And the file is broken there
That's the same file I used with no problem
I even updated on a live server to beta 6 and the problem is still the same... file broken.
@brianteeman how is it possible that for me the file has no content values? the zip should be the same for everyone isn't it? Additionally the live update should be the same.
@brianteeman i'm seeing that only certain icons are not displaying.... for example not working:
working:
Maybe there is something here https://fontawesome.com/changelog/latest
The "encoding" issue you see is due to the PR I made to move Joomla from node-sass to dart-sass: #31290
As far as I can tell, it doesn't have an effect on the rendered icons.
Compiling the data as opposed to the actual files may overcome this, but then you've got the @import
hell that comes with it.
Else you can revert the PR and update to the latest version of node-sass, however it's deprecated
Thanks for the explanation
Thanks for the explanation and to inform us. Not sure where we should go here.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-24 15:03:54 |
Closed_By | ⇒ | joeforjoomla |
Next time instead of ranting @ me et al perhaps you could explain your viewpoint. I would've explained that thats a failure of dart. I hate it too
Could you please change the title of your issue so that it is more precise.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31470.