[#3147] - [#32311] Add repeatable Form Field to Tiny
- Closed
- 3 May 2015
- Medium
- Build: staging
- # 3147
- Diff
- wilsonge:repeatable
- Foreign ID 32311
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Same as #2252 but to staging
Description
The custom templates loaded in tinymce had to be done in a different way as of Tiny3 (currently they were hardcoded in as a temporary method). The time has come for them to be properly coded in. This uses the repeatable form field entered into service with Joomla 3.2 to achieve this.
Testing
Apply this PR and #3574
Edit the tinymce plugin and check the repeatable form field exists (it's 3rd from bottom in the advanced tab) and opens correctly and that save and close buttons work as expected.
The button is here:
The button should open a modal like this (note it may open right at the top of the page rather than in front of you):
Test that adding a tinymce template works as expected and that you can use the existing or a custom template when creating an article
Bakual
- 
Bug is that if you click on the repeatable form field, press close in the modal, then reopen again then you get everything mega duplicated :(
what is a repeatable form field?
A 3.2 feature that we added. This was gonna be the main core use case
apply patch. edit tinymce plugin and go to the templates field and you should see it
| Title |
|
||||||
Can you update the test instructions on the joomlacode issue please
Let's wait on that one.
We should normally get this one
#3912 (comment)
in 3.4
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-27 10:49:18 |
| Status | Closed | ⇒ | New |
nicksavov
- | Labels |
Removed:
?
|
||
Please test this in combination with #3574
@wilsonge @test successful in combination but with a littel comment/note. But i don't know if it is a issue here or in #3574. Please see on your own picture with the modal the "+" buton on the top (next to description) is a green button but with a "-" instead of a "+" in it.
Please do not forget that we have totally changed the way we get/display templates in #3912
bfa1871#diff-d93fcfa294cc59e70963805efe9f303b
This means this PR is not good anymore.
| Status | New | ⇒ | Pending |
I think this is a better method as it gives more flexability than that other PR personally (note it doesn't display the templates at all except for in the editor itself). And the reason that was merged was because this wasn't quite ready at the time. I would add when I wrote that tiny code the intention was to use this as a demo case for using the form field...
#3912 is still only in 3.4-dev, it's not a B/C issue to revert the other PR before we ship because it's never been in a public release. So if people prefer this we can still use this instead but we have to make a decision soon
Having said that. The most important thing is to get #3574 merged - that's independent of this but it means the form field itself works. This is just a use case for the form field.
@wilsonge What's the status on this? #3574 is merged but a joomler wrote 12 days ago that he has a better solution.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3147.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 2014-07-27 10:49:18 | ⇒ | 2015-05-03 11:17:06 |
| Closed_By | ⇒ | wilsonge |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Is this still an issue I couldnt replicate it or was it resolved with #3171