Feeling Lucky
?
[#31467] - Move or Copy in Batch funtionality missing in PHP 8
- Closed
- 30 Nov 2020
- Medium
- Build: staging
- # 31467
Steps to reproduce the issue
Install Joomla 3.9.23 with PHP 8 (64 bit but it doesn't matter)
Add some Categories, Articles, and Menu Items.
Use Batch in any of these to copy or move them.
Expected result
That one can copy or move items to other Menus, Article Categories, etc.
Actual result
The Move or Copy option/drop-down is missing from the Batch box.
System information (as much as possible)
Joomla 3.9.23
PHP 8.0.0RC5 (It's Harald's server)
Additional comments
Here's what it looks like missing said option.
joomla-cms-bot
- | Labels |
Added:
?
|
||
HLeithner
- comment
- 23 Nov 2020
Btw. as workaround for php8 it's possible to set the publish filter to "unpublished", "published" or "archived"
b2z
- comment
- 29 Nov 2020
@HLeithner so in this case $published is not numeric?
HLeithner
- comment
- 29 Nov 2020
yes because it empty '' a fix is easy just cast $published to int if you can create a PR I would be happy to merge it.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-30 07:41:18 |
| Closed_By | ⇒ | alikon |
The reason for this is the new string to number comparison in PHP 8 RFC.
Since we use a non type safe comparison in administrator/components/com_content/views/articles/tmpl/default_batch_body.php:27
This evaluates to true in php < 8 and to flase in php >= 8
So we should check the source for all non type safe comparisions and change them... at least in Joomla 4 we changed a lot.
For j3 I would suggest to fix the batch templates and fix reported bugs except someone want's to take the challange to check the codebase for non type safe comparisions.