[#31459] - [4] Add missing validate="CssIdentifier" to blog_class_leading field
- Fixed in Code Base
- 24 Nov 2020
- Medium
- Build: 4.0-dev
- # 31459
- Diff
- ReLater:patch-1
User tests: Successful: Unsuccessful:
References #29108
Summary of Changes
- See code change tabulator above ("Changed files").
Testing Instructions
- Apply patch.
- Enter an invalid CSS selector class for "Blog Class (Leading Articles)" in a featured menu item.
- Addition: ...or in a blog menu item.
- See that saving of menu item is blocked.
- Enter a valid selector.
- See that saving is not blocked.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31459.
@ReLater Could you also check with "blog item" please? Because after entering an invalid class under: Menu Blog > Blog Layout > Blog Class (Leading Articles) I got: Menu saved.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31459.
| Labels |
Added:
?
|
||
Have added commit for blog_class_leading
Do we have the invalid characters documented somewhere? Just thinking what might go in the Help screen.
I think it's easier to define what is allowed.
The official spec.:
https://www.w3.org/TR/CSS21/syndata.html#characters
For me this sentence is sufficient:
In CSS, identifiers (including element names, classes, and IDs in selectors) can contain only the characters [a-zA-Z0-9] and ISO 10646 characters U+00A0 and higher, plus the hyphen (-) and the underscore (_); they cannot start with a digit, two hyphens, or a hyphen followed by a digit. Identifiers can also contain escaped characters and any ISO 10646 character as a numeric code (see next item). For instance, the identifier
"B&W?"may be written as"B\&W\?"or"B\26 W\3F".
Tried again for blog_class_leading. With updated Patch, response: Invalid field: Blog Class (Leading Articles)
Seems OK?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31459.
Tried again for blog_class_leading. With updated Patch, response: Invalid field: Blog Class (Leading Articles)
Seems OK?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31459.
Whenever you enter an invalid CSS class and get a warning: It's a successfull test.
When you enter a valid one and get a warning it's not successful. But then zero-24 should have a look on this issue. Then something is wrong with the new filter rule. And we need the classes you have tested with.
I have tested this item
OK!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31459.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31459.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31459.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31459.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-24 11:07:19 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 0e0553a
Do we have the invalid characters documented somewhere? Just thinking what might go in the Help screen.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31459.