[#31454] - [4.0] #29722 hidden recaptcha v2
- Fixed in Code Base
- 30 Nov 2020
- Medium
- Build: 4.0-dev
- # 31454
- Diff
- hans2103:#29722-hidden-recaptcha-v2
User tests: Successful: Unsuccessful:
Pull Request for Issue #29722 .
Summary of Changes
This PR will add inline styling for the Google invisible reCaptcha v2 and prevents it from hiding behind other elements by adding a huge z-index.
Testing Instructions
- follow the instructions as mentioned on #29722
- apply this patch
- no NPM needed
- repeat the instructions
Actual result BEFORE applying this Pull Request
Google invisible reCaptcha v2 badge is hiding behind other blocks
Expected result AFTER applying this Pull Request
Google invisible reCaptcha v2 badge is in front of other blocks
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
@brianteeman I was not able to find the exact location of the inline styles on the element. And loading an extra css file when this plugin is enabled does not seem to be a better solution then using the proposed style element.
I have tested this item
It works as described, although getting a V2 Key is a pain. It seems to me the obvious place to put the style is in template.css. Will other template developers want to use a different z-index?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31454.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31454.
| Labels |
Added:
?
|
||
| Category | Front End Plugins | ⇒ | Repository NPM Change Front End Plugins |
I have tested this item
It still works. Do we have any information on the extra time needed to fetch a style sheet containing one line?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31454.
The reason I added is using inline styling was to prevent an extra httpRequest.
You can add it to existing template css, no need inline css or separated css file.
It is template styling issue, not reCaptcha issue
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31454.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31454.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-30 15:11:12 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Thanks!
can it please be done without using an inline style