Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31448] - [4.0] Delete unused contact lang string

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
21 Nov 2020

Follow up on #31439

Summary of Changes

Deleting COM_CONTACT_EDIT_DETAILS="Edit contact information displayed on an individual page."
The string is not used at all in J4

Can be merged on review

avatar infograf768 infograf768 - open - 21 Nov 2020
avatar infograf768 infograf768 - change - 21 Nov 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2020
Category ⇒ Administration Language & Strings
avatar adj9 adj9 - test_item - 21 Nov 2020 - Not tested
avatar adj9
adj9 - comment - 21 Nov 2020

I have not tested this item.

PR is applicable, but how do I verify? By code inspection?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31448.

avatar infograf768
infograf768 - comment - 21 Nov 2020

The only place where it is still present in J4

	<fieldset name="details" label="COM_CONTACT_CONTACT_DETAILS">
		<field
			name="@text_details"
			type="note"
			label=""
			description="COM_CONTACT_EDIT_DETAILS"
		/>

which is to be deleted in #31439

avatar ceford
ceford - comment - 21 Nov 2020

The diff shows only removal of the string from the .ini file. It ought to be removed from the xml file too. Otherwise it ought to have _DESC on the end.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31448.

avatar infograf768
infograf768 - comment - 21 Nov 2020

@ceford
Look at #31439
The field will be deleted when staging is merged into 3.10, and then to j4

avatar richard67
richard67 - comment - 21 Nov 2020

Similar as with PR #30399 , where we have to wait with merging, too, until the XML change has found its way up from staging to 4.0-dev.

avatar brianteeman
brianteeman - comment - 21 Nov 2020

just merge it

avatar infograf768 infograf768 - change - 10 Dec 2020
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 10 Dec 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31448.
avatar wilsonge wilsonge - change - 14 Dec 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-12-14 17:14:35
Closed_By ⇒ wilsonge
Labels Added: ? ? ?
avatar wilsonge wilsonge - close - 14 Dec 2020
avatar wilsonge wilsonge - merge - 14 Dec 2020
avatar wilsonge
wilsonge - comment - 14 Dec 2020

Thanks!

Add a Comment

Login with GitHub to post a comment