Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31435] - [3.9] com_contact icon settings are not available in the administrator contact form even thought they are defined

Information Required ?
avatar shoulders
shoulders
20 Nov 2020

Steps to reproduce the issue

create a new contact or edit a contact and you will find there are no options to define the different types of icons as you can in the component global options
image

These icons parameters are defined in administrator/models/forms/contact.xml but are not rendered in the form to set icons on a per contact basis.

joomla-cms/administrator/components/com_contact/models/forms/contact.xml

Lines 238 to 296 in a5b37ed

<field
name="contact_icons"
type="list"
label="COM_CONTACT_FIELD_ICONS_SETTINGS"
description="COM_CONTACT_FIELD_ICONS_SETTINGS_DESC"
default="0"
>
<option value="0">COM_CONTACT_FIELD_VALUE_NONE</option>
<option value="1">COM_CONTACT_FIELD_VALUE_TEXT</option>
<option value="2">COM_CONTACT_FIELD_VALUE_ICONS</option>
</field>
<field
name="icon_address"
type="media"
label="COM_CONTACT_FIELD_ICONS_ADDRESS_LABEL"
description="COM_CONTACT_FIELD_ICONS_ADDRESS_DESC"
hide_none="1"
/>
<field
name="icon_email"
type="media"
label="COM_CONTACT_FIELD_ICONS_EMAIL_LABEL"
description="COM_CONTACT_FIELD_ICONS_EMAIL_DESC"
hide_none="1"
/>
<field
name="icon_telephone"
type="media"
label="COM_CONTACT_FIELD_ICONS_TELEPHONE_LABEL"
description="COM_CONTACT_FIELD_ICONS_TELEPHONE_DESC"
hide_none="1"
/>
<field
name="icon_mobile"
type="media"
label="COM_CONTACT_FIELD_ICONS_MOBILE_LABEL"
description="COM_CONTACT_FIELD_ICONS_MOBILE_DESC"
hide_none="1"
/>
<field
name="icon_fax"
type="media"
label="COM_CONTACT_FIELD_ICONS_FAX_LABEL"
description="COM_CONTACT_FIELD_ICONS_FAX_DESC"
hide_none="1"
/>
<field
name="icon_misc"
type="media"
label="COM_CONTACT_FIELD_ICONS_MISC_LABEL"
description="COM_CONTACT_FIELD_ICONS_MISC_DESC"
hide_none="1"
/>

Expected result

If the options are defined in the contact.xml they should be rendered or the referenced should be removed.

Actual result

These fields are not rendered but are referenced in the template.

System information (as much as possible)

Setting Value
 
PHP Built On Windows NT E6540 10.0 build 19041 (Windows 10) AMD64
Database Type mysql
Database Version 5.5.5-10.4.10-MariaDB
Database Collation utf8mb4_unicode_ci
Database Connection Collation utf8mb4_general_ci
PHP Version 7.3.12
Web Server Apache/2.4.41 (Win64) OpenSSL/1.1.1c PHP/7.3.12
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.9.22 Stable [ Amani ] 6-October-2020 15:00 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0

Additional comments

I had a quick look and it appears this issue is present in J4.x

avatar shoulders shoulders - open - 20 Nov 2020
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 20 Nov 2020
avatar shoulders shoulders - change - 20 Nov 2020
Title
…
com_contact icon settings are not available in the administrat contact form even thought they are defined
com_contact icon settings are not available in the administrator contact form even thought they are defined
avatar shoulders shoulders - edited - 20 Nov 2020
avatar drmenzelit
drmenzelit - comment - 20 Nov 2020

What do you mean? Do you want to have different icons in each individual contact?

avatar shoulders
shoulders - comment - 20 Nov 2020

Do you want to have different icons in each individual contact? = this is what I am discussing. ?

I am not for or against this feature, it is just these input definitions are present and are not used.

so one of the following is required:

  1. remove the unused definitions in contact.xml and just have the global options defined in the component.
  2. correct the edit template to use these input fields

It is probably easier to remove the values in the contact.xml as I am not sure anyone has ever been able to use them on a per contact basis. However I would like to point you to the install.sql file which shows these options:

joomla-cms/installation/sql/mysql/joomla.sql

Line 503 in a5b37ed

(8, 0, 'com_contact', 'component', 'com_contact', '', 1, 1, 1, 0, '', '{"contact_layout":"_:default","show_contact_category":"hide","save_history":"1","history_limit":10,"show_contact_list":"0","presentation_style":"sliders","show_tags":"1","show_info":"1","show_name":"1","show_position":"1","show_email":"0","show_street_address":"1","show_suburb":"1","show_state":"1","show_postcode":"1","show_country":"1","show_telephone":"1","show_mobile":"1","show_fax":"1","show_webpage":"1","show_image":"1","show_misc":"1","image":"","allow_vcard":"0","show_articles":"0","articles_display_num":"10","show_profile":"0","show_user_custom_fields":["-1"],"show_links":"0","linka_name":"","linkb_name":"","linkc_name":"","linkd_name":"","linke_name":"","contact_icons":"0","icon_address":"","icon_email":"","icon_telephone":"","icon_mobile":"","icon_fax":"","icon_misc":"","category_layout":"_:default","show_category_title":"1","show_description":"1","show_description_image":"0","maxLevel":"-1","show_subcat_desc":"1","show_empty_categories":"0","show_cat_items":"1","show_cat_tags":"1","show_base_description":"1","maxLevelcat":"-1","show_subcat_desc_cat":"1","show_empty_categories_cat":"0","show_cat_items_cat":"1","filter_field":"0","show_pagination_limit":"0","show_headings":"1","show_image_heading":"0","show_position_headings":"1","show_email_headings":"0","show_telephone_headings":"1","show_mobile_headings":"0","show_fax_headings":"0","show_suburb_headings":"1","show_state_headings":"1","show_country_headings":"1","show_pagination":"2","show_pagination_results":"1","initial_sort":"ordering","captcha":"","show_email_form":"1","show_email_copy":"0","banned_email":"","banned_subject":"","banned_text":"","validate_session":"1","custom_reply":"0","redirect":"","show_feed_link":"1","sef_advanced":0,"sef_ids":0,"custom_fields_enable":"1"}', '', '', 0, '0000-00-00 00:00:00', 0, 0),

As far as I know you dont have to define these options (i.e. icon_fax) in the contact.xml to be able to use the global option equivalent.

avatar drmenzelit drmenzelit - change - 20 Nov 2020
Title
…
com_contact icon settings are not available in the administrator contact form even thought they are defined
[3.9] com_contact icon settings are not available in the administrator contact form even thought they are defined
avatar drmenzelit drmenzelit - edited - 20 Nov 2020
avatar Quy
Quy - comment - 7 Jun 2021

@HLeithner Should #34418 be ported to J3? This is not a bug per se. If no, can this be closed?

avatar Quy Quy - change - 7 Jun 2021
Labels Added: Information Required
avatar Quy Quy - labeled - 7 Jun 2021
avatar HLeithner HLeithner - change - 8 Jun 2021
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-06-08 07:28:25
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 8 Jun 2021
avatar HLeithner
HLeithner - comment - 8 Jun 2021

I would expect the fields would work they are not displayed in the backend. On the other side no one seems to miss them the last 10 years or so.

I would keep them in 3.9, I'm not sure if we get any side effects removing them (don't think so) but they are already removed in #34418 so keep them in 3.x series and we are safe.

Closing this because it's solved in 4.0

Add a Comment

Login with GitHub to post a comment