totally borked in chrome but as above in FF

Works fine in FF and Safari.

In chrome the issue comes from the form control height:

.form-control {
    display: block;
    width: 100%;
    height: calc(1.5em + 1.2rem + 2px);  // HERE is the issue.
    padding: .6rem 1rem;
    font-size: 1rem;
    font-weight: 400;
    line-height: 1.5;
    color: #495057;
    background-color: #fff;
    background-clip: padding-box;
    border: 1px solid #ced4da;
    border-radius: .25rem;
    transition: border-color .15s ease-in-out,box-shadow .15s ease-in-out;
}

If we comment the height, all is fine.

Chrome now renders properly

I have tested this item ✅ successfully on 072b56c

Unless I am reading this wrong this file will generate invalid markup if this condition is not met
<?php if ($n === 1 || $i === 0 || $bscolumns === 1 || $i % $bscolumns === 0) : ?>

As we will end up a with a list of li without any wrapping ul

Unless I am reading this wrong this file will generate invalid markup if this condition is not met
<?php if ($n === 1 || $i === 0 || $bscolumns === 1 || $i % $bscolumns === 0) : ?>

As we will end up a with a list of li without any wrapping ul

Correct. But thats as desired. We want it to fail because then we're still parsing tag items. We only want it to succeed on new groups.
$i=0 guarantee's we'll ALWAYS use it at least once.

So why not move the ul out of the for each item loop and then you dont need any of the conditions

I didn't write the code, however, to answer your question, because each nth item will require a new row ( ul ) because the number of optional columns has been reached. I know its confusing, I had to spend a few minutes wrapping my head around it. I probably would've done it differently myself.

If you are saying that the code generates multiple lists then that is wrong markup - it should be one list

Agree. It must be one list to be semantically correct. @N6REJ it is not your fault.

I have another question: The column param - isn't it old fashioned in times of mobile first?
Why not choose "vertical" or "horizontal" and then let it be flexible?

ok, I'll examine the code and see how I can make it better...
@brianteeman they have it as several lists to contain it to n items per row.

CAN we change this behavior? Doing so will break b/c as far as I can tell.

And if we do do it, how/what changes do we make do the db? @richard67

We can break b/c but ideally we should aim not to. In this case if J3 also has this incorrect code then you are fixing a bug not breaking b/c

I usually do this in css with column-count

if tag_columns = default
echo the list
else
echo inline style

but @chmst approach is also valid

ok, so how do we come to a consensus as to the best plan of action. I put a short survey out on glip but so far no responses.
Talking to alison she wants control on desktop and flow on mobile. Seems like christianne wants flow period.

I'm open to changing things just want to all get on the same page and do whats best for the project.

What if we give them an additional parameter to turn columnar sizing on/off. If off it would fit as many in a row as possible.

is

supposed to limit the # of tags? If so its broken

@brianteeman @chmst this thing is taking on a life of its own :P
should we merge this one and create another for the changes that will be needed/desired? I've got a poll out on the fb group right now and its producing some interesting feedback.

works based on # of columns. If columns = 0 then its flex flow so everything just flows & sizes automatically, if columns = 1 it's vertical layout, else its columnar layout.

As long as it is only one list I dont care

it is

I can't apply this PR, with J! Patch Tester

@adj9 Testing sample data is not available in a normal installation which has been made with an installation package. It is only available if you are working on a development environment, i.e. a git clone. That's why patchtester can't apply the patch for testing sample data on an installation where this kind of sample data is not included.

@N6REJ Drone reposts SCSS code style errors here: https://ci.joomla.org/joomla/joomla-cms/37681/1/20. Please fix. Thanks in advance.

Looked at this today - works on Firefox, Chrome and Safari on Mac. But items don't wrap on narrow screens - so if you set 4 columns you get four really narrow columns.

@ceford thats by design. If you set 0 then it will use responsive behaviors. If you set 4 it assumes you know its 4 columns regardless of screen size.

@N6REJ Please fix conflicts. Thanks.