Warning: Use of undefined constant none - assumed 'none' (this will throw an Error in a future version of PHP) in C:\htdocs\joomla-cms\components\com_fields\layouts\fields\render.php on line 91

If you dont enter a class then it should not output an empty class. Currently you get for example <ul class="">

@ceford Please use tabs and not spaces to indent code, see PHP CS errors reported by drone: https://ci.joomla.org/joomla/joomla-cms/37579/1/6

Depending on the options you select they are either ignored or they generate invalid mark

You cannot have the following markup

<p>title</p>
<li>field1</li>
<li>field2</li>

But it gets much worse with other combinations

Not sure what the show/hide title is supposed to do but I couldnt see it doing anything

I have tested this item ? unsuccessfully on 29a934a

Thanks for the fixes - getting better

This generates the following

I get why you made it do that - p and dl would be invalid but I you should not be able to select an invalid option or combination in the first place. Otherwise users will think it is broken

It's the same when you set title to hide on a dl. The title is not hidden because it would be invalid

Thanks to @brianteeman for obliging me to think about the form behaviour. After wondering how to compose some javascript and poking around I discovered that all I had to do was add a field attribute to the form xml: showon="show_title:1[AND]render_tag:ul,ol,p,div" which I can only describe as absolutely marvelous. My complements to the javascript developers. I wonder if this sort of stuff is documented somewhere?

I wonder if this sort of stuff is documented somewhere?

https://docs.joomla.org/Form_field#Showon

I have tested this item ? unsuccessfully on 092e829

https://tinyurl.com/y5r5ys4z

@ashvini77 you can add a screenshot here so user don't have to open a link.

I have tested this item ✅ successfully on 092e829

Yes, After adding the patch, it works correctly

I have tested this item ✅ successfully on 092e829

It works only if when I save that field group after applying the patch again.

The bug occurs when you set up the test groups before applying the patch. To fix it, apply the patch and then open each Field Group in turn and save. That updates the parameters. I have change the code for backward compatibility purposes. You still need to save the Field Groups with the new features to store them. Please test again.

Pity this is stuck in limbo. All tests have passed and the adverse comments resulted from testing procedure.

Nice feature, for sure something for 4.1

Why put this off for 4.1? It was always intended for 4.0.

@wilsonge Your opinion on this? 4.0 or 4.1?

This came up as a gripe in the forum because switching custom fields from dl to ul in J4 ruined perfectly good article appearance. Put it off to 4.1 and expect a lot more gripes!

That gripe was already resolved. This adds new functionality

That gripe was already resolved. This adds new functionality

Exactly. It's a really good enhancement but we should stop adding new stuff into 4.0 to get it released. But with a bit of clean up, we'll have it in 4.1.

@ceford Can you please commit this changes so we can test this again.

Any chance someone else can pick this up? Right now I don't know what to do - too long ago for may failing memory.

I have made a complete pig's ear of the changes requested by Phil. My local repo is in a mess and I don't know how to fix it or revoke my latest commit. Annoyed with myself and ...

I am going to have to redo this from scratch starting from a new repo clone.