Feeling Lucky
?
?
[#31404] - Fix debug plugin call round with a string (php 8)
- Closed
- 18 Nov 2020
- Medium
- Build: staging
- # 31404
- Diff
- HLeithner:j3/debug-php8
User tests: Successful: Unsuccessful:
Cast memory from string to float.
Using the debug plugin on php 8 raises an error.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
HLeithner
- comment
- 14 Nov 2020
how should it fix it ($currentMem > $this->previousMem ? '+' : '') . ($currentMem - $this->previousMem) ends in a string.
SharkyKZ
- comment
- 14 Nov 2020
That shouldn't be an issue, as long as the string is formatted as a number. PHP will cast it to int or float in such case.
HLeithner
- comment
- 14 Nov 2020
Please try it your self I got a type error.
alikon
- comment
- 16 Nov 2020
before apply pr with php 8.0 rc3
after pr
no more error
alikon
- comment
- 16 Nov 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31404.
alikon
- comment
- 18 Nov 2020
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31404.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-18 21:13:27 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
Didn't #30582 fix this?