[#31398] - [4.0] Add possibility to add a custom path in media field
- Closed
- 28 Nov 2020
- Medium
- Build: 4.0-dev
- # 31398
- Diff
- Razzo1987:patch-2
User tests: Successful: Unsuccessful:
Pull Request for Issue #28852 .
Summary of Changes
Enable the media field for input custom url
Testing Instructions
Enable the patch, try to create an article and set a custom URL in the Intro Image, for example https://via.placeholder.com/350x150
Actual result BEFORE applying this Pull Request
You can not insert custom URL:
Expected result AFTER applying this Pull Request
You can insert custom URL and after save the preview is displayed:
Documentation Changes Required
NO
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Title |
|
||||||
In J3 there is a validation from the URL?
In J3 there is a validation from the URL?
No and that was wrong and fixed in J4
The feature of "validate the URL" is planned for J4.0 or J4.1 (or higher)?
The feature of "validate the URL" is planned for J4.0 or J4.1 (or higher)?
No AFAIK
What do you think about enable the field in J4.0 and disable in the release in which the feature is added?
So in J4.0 we can add custom URL as in J3.x
If someone input in J4.0 a non valid URL in the filed is the same issue as he input in J3.x and then update to J4.0
@Razzo1987 Also a more broad comment here:
Allowing any kind of url in that field is allowing basically what is known as hotlinking which in most cases is plain plagiarism ( https://simple.wikipedia.org/wiki/Hotlinking ). If you need an image in your site upload it there. If you're advanced user and you need the ability of freely inserting URLs then create an override and remove the readonly attribute (good luck providing all the needed width and height params for correctly using lazyloading: #30784 ).
So in J4.0 we can add custom URL as in J3.x
This was an intended change (eg prevents hotlinking and allows the media manager integration the way it was envisioned). So from me it's a no. IMO the core shouldn't allow manually inserted url's in the media field
I have tested this item
Done
Frontend - Category List Articles
- Article
Backend
- Insert this img
If you change the URL to an invalid one (https://www.wiki) there is currently no control.
Checking it seems useful to me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31398.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31398.
set RTC
why not RTC?
why not RTC?
Read my comments, this PR is wrong!!!
then close it
@gostn FYI, @dgrammatiko is not authorised to close a PR.
Only the original poster and maintainers/dev leaders can.
@Razzo1987
I'm afraid Dimitris is right. Closing the PR now. Thanks for the proposal.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-28 09:54:00 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
Sorry but this is wrong as explained already #28852 (comment). You can do that in your installation (eg layout override) but not for core, you're breaking the intended functionality