[#31389] - [4.x] Tinmyce image decorative [a11y]
- Fixed in Code Base
- 12 Nov 2020
- Medium
- Build: 4.0-dev
- # 31389
- Diff
- brianteeman:tiny
User tests: Successful: Unsuccessful:
This PR enables the native tinymce feature to mark an image as decorative. This continues the work started in #31318 and #31323
Background
To read why this change is very important see #31318
Testing Part 1
Testing is really easy. No npm, js or css involved.
Merge the pull request and then use the tinmyce image button to add an image
The new options is highlighted here
Testing Part 2
Please test three scenarios
-
Image Description (Alt Text) = Empty
Images is decorative = unchecked -
Image Description (Alt Text) = "some description"
Images is decorative = unchecked -
Image Description (Alt Text) = Empty
Images is decorative = checked
The expected behaviour for each of these tests is
1.<img src="filename.jpg" width="xx" height="xx" />
2. <img src="filename.jpg" alt="some description" width="xx" height="xx" />
3. <img role="presentation" src="filename.jpg" alt width="xx" height="xx" />
3. <img role="presentation" src="filename.jpg" alt="" width="xx" height="xx" />
PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.
Bonus
I have grouped the three image options together in the code.
cc @carcam
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
Sorry, HTML code is not visible, I repeat it here:
1. <img src="images/joomla_black.png" width="225" height="50" />
2. <img src="images/joomla_black.png" alt="some description" width="225" height="50" />
3. <img role="presentation" src="images/joomla_black.png" alt="" width="225" height="50" />
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/31389">issues.joomla.org/tracker/joomla-cms/31389</a>.</sub>
I have tested this item
I have tested this item and it works perfectly.
Thank you.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31389.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31389.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-12 21:05:13 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
?
|
||
Thanks!
Thanks
I have tested this item✅ successfully on a7eace8
I've tested it successfully with Joomla 4 beta 6 daily build. This is the result:
Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31389.