Success

User tests: Successful: Unsuccessful:

avatar CrandellWS
CrandellWS
17 Feb 2014

This has cause problems such as described here: http://forum.joomla.org/viewtopic.php?f=708&t=789859

Many people have mentioned putting a space before the class "nav-pills" this is the reason that this pull is needed.

avatar CrandellWS CrandellWS - open - 17 Feb 2014
avatar mbabker
mbabker - comment - 17 Feb 2014

It's a purposeful decision to not include the space in the layout. As is, a user can either completely change the appearance by changing a class name or add additional classes by starting their input with a space.

avatar mbabker mbabker - change - 17 Feb 2014
The description was changed
Description <p>this has cause problems such as described here: <a href="http://forum.joomla.org/viewtopic.php?f=708&amp;t=789859">http://forum.joomla.org/viewtopic.php?f=708&amp;t=789859</a></p> <p>Many people have mentioned putting a space before the class "nav-pills" this is the reason that is needed.</p> <p>This has cause problems such as described here: <a href="http://forum.joomla.org/viewtopic.php?f=708&amp;t=789859">http://forum.joomla.org/viewtopic.php?f=708&amp;t=789859</a></p> <p>Many people have mentioned putting a space before the class "nav-pills" this is the reason that this pull is needed.</p>
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-02-17 18:14:00
avatar mbabker mbabker - close - 17 Feb 2014
avatar mbabker mbabker - close - 17 Feb 2014
avatar brianteeman
brianteeman - comment - 17 Feb 2014

This would break backwards compatibility and all the documentation which states to use a space http://docs.joomla.org/Using_Class_Suffixes

avatar CrandellWS
CrandellWS - comment - 17 Feb 2014

Thanks for the information... I still believe providing a simple solution to fix an issue that one may have done X^100 for each menu item they created and expected this result.

I am aware of the backwards compatibility issues and that's a perfect doc link.

avatar CrandellWS
CrandellWS - comment - 17 Feb 2014

Has a global Boolean been considered to allow for more of a dynamic resolution as opposed to manual.

avatar Bakual
Bakual - comment - 17 Feb 2014

A boolean for what? It's a "suffix" field, it's not an "additional class" field.
It works perfectly fine as it is as long as you understand what a suffix is.
I don't want to make that code more complicate than needed.

avatar CrandellWS
CrandellWS - comment - 17 Feb 2014

that would indeed make he source more complex. The basic Idea I was saying
a boolean to mass change the suffix...alternatively one can create a
separate style sheet and accomplish the same without the need for "extra
source", and for this I am aware. It is not a huge deal.

Though as was stated adding or removing that space does make a difference,
being able to change it on the fly was the idea, and again load a different
style sheet can get the same results.

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=29771

As it is shown, it was as it is, then as described, and now back to as is.

In translation how many people were effected by this? Could a Boolean
option be a relief for those who spent hours upon hours of (manual none sql
inserted) data inputs only to find on the upgrade path everything brakes,
and all they know how to do is input data into html forms not design them,
and even less likely tamper with the php source, as an easy fix.

Yes I am only describing a small subset of Joomla users, but from just a
few moments of checking this seems to have effected multiple Joomla users
in a very negative way. At least with a Boolean option they could attempt
to revert one way or the other in bulk.

It has been described how to do and undo this for those who is will to play
with the source but leaves no option other than manually fixing every entry
for those who are none dev type users. That could be just a couple of menu
links or a couple of thousand that they will have to manually fix.

On Mon, Feb 17, 2014 at 1:43 PM, Thomas Hunziker
notifications@github.comwrote:

A boolean for what? It's a "suffix" field, it's not an "additional class"
field.
It works perfectly fine as it is as long as you understand what a suffix
is.
I don't want to make that code more complicate than needed.


Reply to this email directly or view it on GitHub#3138 (comment)
.

avatar Bakual
Bakual - comment - 17 Feb 2014

That could be just a couple of menu
links or a couple of thousand that they will have to manually fix.

We are talking about the menu class suffix, right? That's not likely to be thousands (that would be crazy!). That's one per menu module. That's easy to fix.

avatar CrandellWS
CrandellWS - comment - 17 Feb 2014

menu => per site => per lang => group => per ACL => per user.

Most people who ran into this problem would likely have only a few places
to fix it...

But this is becoming a dead horse...

I don't have this problem...

On Mon, Feb 17, 2014 at 4:19 PM, Thomas Hunziker
notifications@github.comwrote:

That could be just a couple of menu
links or a couple of thousand that they will have to manually fix.

We are talking about the menu class suffix, right? That's not likely to be
thousands (that would be crazy!). That's one per menu module. That's easy
to fix.


Reply to this email directly or view it on GitHub#3138 (comment)
.

Add a Comment

Login with GitHub to post a comment